[
https://issues.apache.org/jira/browse/DRILL-6032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16353076#comment-16353076
]
ASF GitHub Bot commented on DRILL-6032:
---------------------------------------
Github user ppadma commented on a diff in the pull request:
https://github.com/apache/drill/pull/1101#discussion_r166098364
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/aggregate/HashAggTemplate.java
---
@@ -140,6 +131,9 @@
private OperatorContext oContext;
private BufferAllocator allocator;
+ private Map<String, Integer> keySizes;
+ // The size estimates for varchar value columns. The keys are the index
of the varchar value columns.
+ private Map<Integer, Integer> varcharValueSizes;
--- End diff --
Don't you need to adjust size estimates for repeated types also ?
> Use RecordBatchSizer to estimate size of columns in HashAgg
> -----------------------------------------------------------
>
> Key: DRILL-6032
> URL: https://issues.apache.org/jira/browse/DRILL-6032
> Project: Apache Drill
> Issue Type: Improvement
> Reporter: Timothy Farkas
> Assignee: Timothy Farkas
> Priority: Major
> Fix For: 1.13.0
>
>
> We need to use the RecordBatchSize to estimate the size of columns in the
> Partition batches created by HashAgg.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
