[
https://issues.apache.org/jira/browse/DRILL-5978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16353547#comment-16353547
]
ASF GitHub Bot commented on DRILL-5978:
---------------------------------------
Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/1111#discussion_r166209232
--- Diff:
contrib/storage-hive/core/src/main/java/org/apache/drill/exec/store/hive/HiveMetadataProvider.java
---
@@ -264,6 +265,10 @@ private HiveStats
getStatsEstimateFromInputSplits(final List<LogicalInputSplit>
final List<LogicalInputSplit> splits = Lists.newArrayList();
final JobConf job = new JobConf(hiveConf);
HiveUtilities.addConfToJob(job, properties);
+ if (AcidUtils.isTablePropertyTransactional(properties)) {
+ AcidUtils.setTransactionalTableScan(job, true);
+ HiveUtilities.setColumnTypes(job, properties, true, sd);
+ }
--- End diff --
How about refactoring this block of code to a new method in HiveUtilities ?
Like `verifyAndAddTransactionalProperty()`. Then just call that method from
both here and HiveAbstractReader
> Upgrade Hive libraries to 2.1.1 version.
> ----------------------------------------
>
> Key: DRILL-5978
> URL: https://issues.apache.org/jira/browse/DRILL-5978
> Project: Apache Drill
> Issue Type: Improvement
> Components: Storage - Hive
> Affects Versions: 1.11.0
> Reporter: Vitalii Diravka
> Assignee: Vitalii Diravka
> Priority: Major
> Labels: doc-impacting
> Fix For: 1.13.0
>
>
> Currently Drill uses [Hive version 1.2.1
> libraries|https://github.com/apache/drill/blob/master/pom.xml#L53] to perform
> queries on Hive. This version of library can be used for Hive1.x versions and
> Hive2.x versions too, but some features of Hive2.x are broken (for example
> using of ORC transactional tables). To fix that it will be good to update
> drill-hive library version to 2.1 or newer.
> Tasks which should be done:
> - resolving dependency conflicts;
> - investigating backward compatibility of newer drill-hive library with older
> Hive versions (1.x);
> - updating drill-hive version for
> [MapR|https://github.com/apache/drill/blob/master/pom.xml#L1777] profile too.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
