[ https://issues.apache.org/jira/browse/DRILL-6032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16365042#comment-16365042 ]
ASF GitHub Bot commented on DRILL-6032: --------------------------------------- Github user Ben-Zvi commented on a diff in the pull request: https://github.com/apache/drill/pull/1101#discussion_r168363813 --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/agg/TestHashAggrSpill.java --- @@ -93,7 +93,7 @@ private void testSpill(long maxMem, long numPartitions, long minBatches, int max @Test public void testSimpleHashAggrSpill() throws Exception { testSpill(68_000_000, 16, 2, 2, false, - true, null, 1_200_000, 1, 1, 1, 3); + true, null, 1_200_000, 1, 2, 1, 3); --- End diff -- This is supposed to be a "simple spill" (see comment above); not a "recursive" one (with cycle > 1). Maybe just reducing the number of rows would do the trick .... > Use RecordBatchSizer to estimate size of columns in HashAgg > ----------------------------------------------------------- > > Key: DRILL-6032 > URL: https://issues.apache.org/jira/browse/DRILL-6032 > Project: Apache Drill > Issue Type: Improvement > Reporter: Timothy Farkas > Assignee: Timothy Farkas > Priority: Major > Fix For: 1.13.0 > > > We need to use the RecordBatchSize to estimate the size of columns in the > Partition batches created by HashAgg. -- This message was sent by Atlassian JIRA (v7.6.3#76005)