[jira] [Commented] (DRILL-6174) Parquet pushdown planning improvements

[ASF GitHub Bot (JIRA)]

    [ 
https://issues.apache.org/jira/browse/DRILL-6174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16377057#comment-16377057
 ] 

ASF GitHub Bot commented on DRILL-6174:
---------------------------------------

Github user arina-ielchiieva commented on a diff in the pull request:

    https://github.com/apache/drill/pull/1131#discussion_r170629893
  
    --- Diff: 
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetFilterBuilder.java
 ---
    @@ -261,6 +273,37 @@ private LogicalExpression 
handleCompareFunction(FunctionHolderExpression functio
         }
       }
     
    +  private LogicalExpression handleIsFunction(FunctionHolderExpression 
functionHolderExpression, Set<LogicalExpression> value) {
    +    String funcName;
    +
    +    if (functionHolderExpression.getHolder() instanceof 
DrillSimpleFuncHolder) {
    +      funcName = ((DrillSimpleFuncHolder) 
functionHolderExpression.getHolder()).getRegisteredNames()[0];
    +    } else {
    +      logger.warn("Can not cast {} to DrillSimpleFuncHolder. Parquet 
filter pushdown can not handle function.",
    +          functionHolderExpression.getHolder());
    +      return null;
    +    }
    +    LogicalExpression arg = functionHolderExpression.args.get(0);
    +
    +    switch (funcName) {
    --- End diff --
    
    Please use proper formatting for switch case.


> Parquet pushdown planning improvements
> --------------------------------------
>
>                 Key: DRILL-6174
>                 URL: https://issues.apache.org/jira/browse/DRILL-6174
>             Project: Apache Drill
>          Issue Type: Improvement
>    Affects Versions: 1.12.0
>            Reporter: Arina Ielchiieva
>            Assignee: Roman Kulyk
>            Priority: Major
>              Labels: doc-impacting
>             Fix For: 1.13.0
>
>
> Currently parquet pushdown planning has certain limitations 
> (https://drill.apache.org/docs/parquet-filter-pushdown/). This Jira aims to 
> fix some of them. List of improvements can be find below:
> 1. IS [NOT] NULL / TRUE / FALSE
> 2. Timestamp / date / time implicit / explicit casts
> {noformat}
> timestamp -> date
> timestamp -> varchar
> date -> timestamp
> date -> varchar
> time -> timestamp
> time -> date
> time -> varchar
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)