[
https://issues.apache.org/jira/browse/DRILL-6188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16378573#comment-16378573
]
ASF GitHub Bot commented on DRILL-6188:
---------------------------------------
GitHub user parthchandra opened a pull request:
https://github.com/apache/drill/pull/1132
DRILL-6188: Fix C++ client build on Centos7, OS X
Removed unused method that didn't compile.
Included iostream for declaration of std::cout
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/parthchandra/drill DRILL-6188
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/drill/pull/1132.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1132
----
commit bf1f90138502300649b0945fcfc2b1b109512b52
Author: Parth Chandra <parthc@...>
Date: 2018-02-27T12:01:51Z
DRILL-6188: Fix C++ client build on Centos7, OS X
----
> Fix C++ client build on Centos 7 and OSX
> -----------------------------------------
>
> Key: DRILL-6188
> URL: https://issues.apache.org/jira/browse/DRILL-6188
> Project: Apache Drill
> Issue Type: Bug
> Reporter: Parth Chandra
> Priority: Major
>
> compile issue on CentOS 7:
> {quote}In file included from
> /root/default/private-drill/contrib/native/client/src/clientlib/utils.cpp:22:0:
> /root/default/private-drill/contrib/native/client/src/clientlib/logger.hpp:
> In constructor 'Drill::Logger::Logger()':
>
> /root/default/private-drill/contrib/native/client/src/clientlib/logger.hpp:38:29:
> error: 'cout' is not a member of 'std'
> m_pOutStream = &std::cout;
> ^
> make[2]: *** [src/clientlib/CMakeFiles/drillClient.dir/utils.cpp.o] Error 1
> make[1]: *** [src/clientlib/CMakeFiles/drillClient.dir/all] Error 2
> make: *** [all] Error 2
> {quote}
> OSX - has this compile error:
> {quote}In file included from
> /Users/mapr/private-drill/contrib/native/client/src/clientlib/drillClientImpl.cpp:34:
>
> /Users/mapr/private-drill/contrib/native/client/src/clientlib/drillClientImpl.hpp:185:39:
> error: 'm_bHasError' is a private member of 'Drill::DrillClientQueryHandle'
> void setHasError(bool hasError)
> Unknown macro: \{ m_bHasError = hasError; }
> ^
>
> /Users/mapr/private-drill/contrib/native/client/src/clientlib/drillClientImpl.hpp:158:10:
> note: declared private here
> bool m_bHasError;
> ^
> {quote}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
