[ 
https://issues.apache.org/jira/browse/DRILL-4120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16380114#comment-16380114
 ] 

ASF GitHub Bot commented on DRILL-4120:
---------------------------------------

GitHub user vvysotskyi opened a pull request:

    https://github.com/apache/drill/pull/1138

    DRILL-4120: Allow implicit columns for Avro storage format

    Existing implementation of `AvroDrillTabl` does not allow dynamic columns 
discovering. `AvroDrillTable.getRowType()` method returns `RelDataTypeImlp` 
instance with the list of all table columns. It forces validator to check 
columns from select list in `RowType` list. It makes impossible to use implicit 
columns.
    
    This fix replaces the usage of `AvroDrillTable` by `DynamicDrillTable` for 
Avro format and also allows usage of non-existent columns in Avro tables to be 
consistent with other storage formats.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/vvysotskyi/drill DRILL-4120

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/drill/pull/1138.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1138
    
----
commit 402accca668481bb6816aad438c867781157fac6
Author: Volodymyr Vysotskyi <vvovyk@...>
Date:   2018-02-27T16:39:22Z

    DRILL-4120: Allow implicit columns for Avro storage format

----


> dir0 does not work when the directory structure contains Avro files
> -------------------------------------------------------------------
>
>                 Key: DRILL-4120
>                 URL: https://issues.apache.org/jira/browse/DRILL-4120
>             Project: Apache Drill
>          Issue Type: Bug
>          Components: Query Planning &amp; Optimization
>    Affects Versions: 1.3.0
>            Reporter: Stefán Baxter
>            Assignee: Volodymyr Vysotskyi
>            Priority: Major
>             Fix For: 1.13.0
>
>         Attachments: 
> 0001-DRILL-4120-Support-reading-directories-having-avro-f.patch
>
>
> Any select statment containing dirN fails if the target directory structure 
> contains Avro files.
> Steps to test:
> 1. create a simple directory structure
> 2. copy an avro file into each directory
> 3. execute a query containing dir0
> outcome:
> Error: VALIDATION ERROR: From line 1, column 117 to line 1, column 120: 
> Column 'dir0' not found in any table



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to