[
https://issues.apache.org/jira/browse/DRILL-6180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16380681#comment-16380681
]
ASF GitHub Bot commented on DRILL-6180:
---------------------------------------
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/1129#discussion_r171314892
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/managed/SortConfig.java
---
@@ -71,8 +72,8 @@
private final int mSortBatchSize;
- public SortConfig(DrillConfig config) {
-
+ public SortConfig(FragmentContext context) {
+ DrillConfig config = context.getConfig();
--- End diff --
Suggestion: pass in the original `DrillConfig` plus an option manager
rather than the fragment context. The suggestion minimizes undesired
dependencies.
> Use System Option "output_batch_size" for External Sort
> -------------------------------------------------------
>
> Key: DRILL-6180
> URL: https://issues.apache.org/jira/browse/DRILL-6180
> Project: Apache Drill
> Issue Type: Improvement
> Components: Execution - Flow
> Affects Versions: 1.12.0
> Reporter: Padma Penumarthy
> Assignee: Padma Penumarthy
> Priority: Critical
> Fix For: 1.13.0
>
>
> External Sort has boot time configuration for output batch size
> "drill.exec.sort.external.spill.merge_batch_size" which is defaulted to 16M.
> To make batch sizing configuration uniform across all operators, change this
> to use new system option that is added
> "drill.exec.memory.operator.output_batch_size". This option has default value
> of 32M.
> So, what are the implications if default is changed to 32M for external sort ?
> Instead, should we change the output batch size default to 16M for all
> operators ?
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
