[ 
https://issues.apache.org/jira/browse/DRILL-5270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16384296#comment-16384296
 ] 

ASF GitHub Bot commented on DRILL-5270:
---------------------------------------

Github user vrozov commented on the issue:

    https://github.com/apache/drill/pull/755
  
    @kkhatua
    1. The read locks are not exclusive (single writer/multiple readers). To 
achieve the required functionality you need to introduce a different lock and 
use write (or exclusive) lock.
    2. The choice for TreeSet is not obvious. What are the most common 
operations performed on the collection? Do you optimize for get, put or 
collection construction?
    
    @arina-ielchiieva my github id is `vrozov`.


> Improve loading of profiles listing in the WebUI
> ------------------------------------------------
>
>                 Key: DRILL-5270
>                 URL: https://issues.apache.org/jira/browse/DRILL-5270
>             Project: Apache Drill
>          Issue Type: Improvement
>          Components: Web Server
>    Affects Versions: 1.9.0
>            Reporter: Kunal Khatua
>            Assignee: Kunal Khatua
>            Priority: Major
>             Fix For: 1.14.0
>
>
> Currently, as the number of profiles increase, we reload the same list of 
> profiles from the FS.
> An ideal improvement would be to detect if there are any new profiles and 
> only reload from the disk then. Otherwise, a cached list is sufficient.
> For a directory of 280K profiles, the load time is close to 6 seconds on a 32 
> core server. With the caching, we can get it down to as much as a few 
> milliseconds.
> To render the cache as invalid, we inspect the last modified time of the 
> directory to confirm whether a reload is needed. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to