[
https://issues.apache.org/jira/browse/DRILL-5994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16384311#comment-16384311
]
ASF GitHub Bot commented on DRILL-5994:
---------------------------------------
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1148#discussion_r171989096
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/WebServer.java
---
@@ -424,10 +418,11 @@ private ServerConnector createHttpsConnector(int
port) throws Exception {
* @return Initialized {@link ServerConnector} instance for HTTP
connections.
* @throws Exception
*/
- private ServerConnector createHttpConnector(int port) throws Exception {
+ private ServerConnector createHttpConnector(int port, int acceptors, int
selectors) throws Exception {
logger.info("Setting up HTTP connector for web server");
final HttpConfiguration httpConfig = new HttpConfiguration();
- final ServerConnector httpConnector = new
ServerConnector(embeddedJetty, new HttpConnectionFactory(httpConfig));
+ final ServerConnector httpConnector =
+ new ServerConnector(embeddedJetty, null, null, null, acceptors,
selectors, new HttpConnectionFactory(httpConfig));
--- End diff --
I don't think there is such constructor (only one that takes
`SslContextFactory` as the last argument), please double check.
> Cannot start web server on a machine with more than 200 cores
> -------------------------------------------------------------
>
> Key: DRILL-5994
> URL: https://issues.apache.org/jira/browse/DRILL-5994
> Project: Apache Drill
> Issue Type: Improvement
> Affects Versions: 1.11.0
> Reporter: Mitchel Labonte
> Assignee: Mitchel Labonte
> Priority: Minor
> Labels: doc-impacting, ready-to-commit
> Fix For: 1.13.0
>
>
> If the WebServer is launched on a machine that has more than 200 cores, you
> get the following stack trace:
> {noformat}
> Exception in thread "main"
> org.apache.drill.exec.exception.DrillStartupException: Failure during initial
> startup of Drillbit:
> at org.apache.drill.exec.server.Drillbit.start(Drillbit.java:313)
> at org.apache.drill.exec.server.Drillbit.start(Drillbit.java:289)
> at org.apache.drill.exec.server.Drillbit.start(Drillbit.java:285)
> Caused by: java.lang.IllegalStateException: Insufficient max threads in
> ThreadPool: max=200 < needed=206
> at org.eclipse.jetty.server.Server.doStart(Server.java:321)
> at
> org.eclipse.jetty.util.component.AbstractLifeCycle.start(AbstractLifeCycle.java:68)
> at org.eclipse.drill.exec.server.rest.WebServer.start(WebServer.java:197)
> at org.eclipse.drill.exec.server.Drillbit.run(Drillbit.java:140)
> at org.eclipse.drill.exec.server.Drillbit.start(Drillbit.java:309)
> ... 2 more
> {noformat}
> The cause of this is that in the WebServer start method, a Server instance is
> created with the default constructor, which initializes a QueuedThreadPool
> with a default maxThreads value of 200, and there is no way to configure this
> value.
> *For documentation*
> New config option - drill.exec.web_server.thread_pool_max.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
