[ 
https://issues.apache.org/jira/browse/DRILL-4120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16388257#comment-16388257
 ] 

ASF GitHub Bot commented on DRILL-4120:
---------------------------------------

Github user arina-ielchiieva commented on a diff in the pull request:

    https://github.com/apache/drill/pull/1138#discussion_r172599233
  
    --- Diff: 
exec/java-exec/src/main/java/org/apache/drill/exec/store/ColumnExplorer.java ---
    @@ -78,6 +79,23 @@ public ColumnExplorer(OptionManager optionManager, 
List<SchemaPath> columns) {
         return map;
       }
     
    +  /**
    +   * Returns list with implicit column names taken from specified {@link 
SchemaConfig}.
    +   *
    +   * @param schemaConfig the source of session options values.
    +   * @return list with implicit column names.
    +   */
    +  public static List<String> getImplicitColumns(SchemaConfig schemaConfig) 
{
    --- End diff --
    
    Please rename
    1. `getImplicitColumns` -> `getImplicitColumnsNames`
    2. `getPartitions` -> `getPartitionColumnNames`


> dir0 does not work when the directory structure contains Avro files
> -------------------------------------------------------------------
>
>                 Key: DRILL-4120
>                 URL: https://issues.apache.org/jira/browse/DRILL-4120
>             Project: Apache Drill
>          Issue Type: Bug
>          Components: Query Planning &amp; Optimization
>    Affects Versions: 1.3.0
>            Reporter: Stefán Baxter
>            Assignee: Volodymyr Vysotskyi
>            Priority: Major
>             Fix For: 1.13.0
>
>         Attachments: 
> 0001-DRILL-4120-Support-reading-directories-having-avro-f.patch
>
>
> Any select statment containing dirN fails if the target directory structure 
> contains Avro files.
> Steps to test:
> 1. create a simple directory structure
> 2. copy an avro file into each directory
> 3. execute a query containing dir0
> outcome:
> Error: VALIDATION ERROR: From line 1, column 117 to line 1, column 120: 
> Column 'dir0' not found in any table



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to