[ 
https://issues.apache.org/jira/browse/DRILL-6217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16392738#comment-16392738
 ] 

ASF GitHub Bot commented on DRILL-6217:
---------------------------------------

Github user arina-ielchiieva commented on a diff in the pull request:

    https://github.com/apache/drill/pull/1154#discussion_r173426691
  
    --- Diff: 
exec/java-exec/src/test/java/org/apache/drill/exec/vector/complex/writer/TestJsonNanInf.java
 ---
    @@ -331,4 +343,63 @@ public void testInnerJoinWithNaN() throws Exception {
         }
       }
     
    +  @Test
    +  public void testHashJoinWithNaN() throws Exception {
    --- End diff --
    
    When do you reset join options (`JoinTestBase.resetJoinOptions()`)?


> NaN/Inf: NestedLoopJoin processes NaN values incorrectly
> --------------------------------------------------------
>
>                 Key: DRILL-6217
>                 URL: https://issues.apache.org/jira/browse/DRILL-6217
>             Project: Apache Drill
>          Issue Type: Bug
>    Affects Versions: 1.12.0
>            Reporter: Volodymyr Tkach
>            Assignee: Volodymyr Tkach
>            Priority: Major
>             Fix For: 1.14.0
>
>         Attachments: ObjsX.json
>
>
> *AFFECTED_FUNCTIONALITY:* INNER JOIN (nestedloopjoin)
> *ISSUE_DESCRIPTION:* according to *nestedloopjoin* query result NaN != NaN, 
> however hashjoin / mergejoin behaves another way - NaN = NaN. As far as I 
> understand, nestedloopjoin should behave like hashjoin / mergejoin. *STEPS*:
> - Upload the attached file to Hadoop fs (ObjsX.json);
> - Setup the following system settings:
>       *set planner.enable_nljoin_for_scalar_only = false*
>       *set planner.enable_hashjoin = false*
>       *set planner.enable_mergejoin = false*
>       *set planner.enable_nestedloopjoin = true*
> - Run the following sql query {code} select distinct t.name from 
> dfs.tmp.`ObjsX.json` t inner join dfs.tmp.`ObjsX.json` tt on t.attr4 = 
> tt.attr4 {code}
>       *EXPECTED_RESULT:* It was expected to get the following result:
>       {code}
>        object1
>        object2
>        object3
>        object4
>       {code}
>       
>       *ACTUAL_RESULT:* The actual result is:
>       {code}
>        object2
>        object3
>        object4
>       {code}
> Please investigate and fix



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to