[ 
https://issues.apache.org/jira/browse/DRILL-6053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16398470#comment-16398470
 ] 

ASF GitHub Bot commented on DRILL-6053:
---------------------------------------

Github user arina-ielchiieva commented on a diff in the pull request:

    https://github.com/apache/drill/pull/1163#discussion_r174433987
  
    --- Diff: pom.xml ---
    @@ -259,7 +259,13 @@
             <groupId>org.apache.maven.plugins</groupId>
             <artifactId>maven-checkstyle-plugin</artifactId>
             <version>2.12.1</version>
    -        <configuration>
    +        <dependencies>
    +          <dependency>
    +            <groupId>com.puppycrawl.tools</groupId>
    +            <artifactId>checkstyle</artifactId>
    +            <version>5.9</version>
    +          </dependency>
    +        </dependencies>        <configuration>
    --- End diff --
    
    1. Please `configuration` move to the next line.
    2. You indicating that we upgrade dependency but in fact we added new?


> Avoid excessive locking in LocalPersistentStore
> -----------------------------------------------
>
>                 Key: DRILL-6053
>                 URL: https://issues.apache.org/jira/browse/DRILL-6053
>             Project: Apache Drill
>          Issue Type: Improvement
>            Reporter: Vlad Rozov
>            Assignee: Vlad Rozov
>            Priority: Major
>             Fix For: 1.14.0
>
>
> When query profiles are written to LocalPersistentStore, the write is 
> unnecessary serialized due to read/write lock that was introduced for 
> versioned PersistentStore. Only versioned access needs to be protected by 
> read/write lock.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to