[
https://issues.apache.org/jira/browse/DRILL-6275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16405458#comment-16405458
]
ASF GitHub Bot commented on DRILL-6275:
---------------------------------------
GitHub user ilooner opened a pull request:
https://github.com/apache/drill/pull/1176
DRILL-6275: Fixed direct memory reporting in sys.memory.
@kkhatua Thanks for pinpointing the root cause! Please review.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ilooner/drill DRILL-6275
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/drill/pull/1176.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1176
----
commit 7f65b7d4b4b9e42dc3597ac9758c39c6ce0903b7
Author: Timothy Farkas <timothyfarkas@...>
Date: 2018-03-19T20:16:37Z
DRILL-6275: Fixed direct memory reporting in sys.memory.
----
> drillbit direct_current memory usage is not populated/updated
> -------------------------------------------------------------
>
> Key: DRILL-6275
> URL: https://issues.apache.org/jira/browse/DRILL-6275
> Project: Apache Drill
> Issue Type: Bug
> Components: Metadata
> Affects Versions: 1.13.0
> Reporter: Chun Chang
> Assignee: Timothy Farkas
> Priority: Minor
>
> We used to keep track drill memory usage in sys.memory. And it was useful in
> detecting memory leaks. This feature seems broken. The direct_current memory
> usage is not populated or updated.
> {noformat}
> 0: jdbc:drill:zk=10.10.30.166:5181> select * from sys.memory;
> +---------------+------------+---------------+-------------+-----------------+---------------------+--------------+
> | hostname | user_port | heap_current | heap_max | direct_current |
> jvm_direct_current | direct_max |
> +---------------+------------+---------------+-------------+-----------------+---------------------+--------------+
> | 10.10.30.168 | 31010 | 1162636800 | 2147483648 | 0 | 22096 | 10737418240 |
> | 10.10.30.169 | 31010 | 1301175040 | 2147483648 | 0 | 22096 | 10737418240 |
> | 10.10.30.166 | 31010 | 989448872 | 2147483648 | 0 | 22096 | 10737418240 |
> | 10.10.30.167 | 31010 | 1767205312 | 2147483648 | 0 | 22096 | 10737418240 |
> +---------------+------------+---------------+-------------+-----------------+---------------------+--------------+
> 4 rows selected (1.564 seconds)
> 0: jdbc:drill:zk=10.10.30.166:5181> select * from sys.version;
> +------------------+-------------------------------------------+-------------------------------------------------------+----------------------------+---------------------+----------------------------+
> | version | commit_id | commit_message | commit_time | build_email |
> build_time |
> +------------------+-------------------------------------------+-------------------------------------------------------+----------------------------+---------------------+----------------------------+
> | 1.13.0-SNAPSHOT | 534212456cc25a49272838cba91c223f63df7fd2 | Cleanup when
> closing, and cleanup spill after a kill | 07.03.2018 @ 16:18:27 PST |
> [email protected] | 08.03.2018 @ 10:09:28 PST |
> +------------------+-------------------------------------------+-------------------------------------------------------+----------------------------+---------------------+----------------------------+
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
