[jira] [Commented] (DRILL-5937) prepare.statement.create_timeout_ms default is 10 seconds but code comment says default should be 10 mins

Mon, 26 Mar 2018 01:44:40 -0700 

    [ 
https://issues.apache.org/jira/browse/DRILL-5937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16413573#comment-16413573
 ] 

ASF GitHub Bot commented on DRILL-5937:
---------------------------------------

GitHub user pushpendra-jaiswal-90 opened a pull request:

    https://github.com/apache/drill/pull/1190

    [DRILL-5937] ExecConstants: changed comment, timeout default is 30 sec.

    **Changed comment** to reflect default prepared statement timeout as 30 
sec. (same as hive) .
    10 seconds timeout is also failing in some cases in our mapr environment.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/pushpendra-jaiswal-90/drill 
bug/DRILL-5937-prepared-timeout-default

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/drill/pull/1190.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1190
    
----
commit 5556e25ed689a9029de27d9a3ad91f02e46b95f2
Author: Pushpendra Jaiswal <pushpendra.jaiswal@...>
Date:   2018-03-26T07:05:51Z

    [DRILL-5937] ExecConstants: changed comment, timeout default is 30 sec.

----


>  prepare.statement.create_timeout_ms default is 10 seconds but code comment 
> says default should be 10 mins
> ----------------------------------------------------------------------------------------------------------
>
>                 Key: DRILL-5937
>                 URL: https://issues.apache.org/jira/browse/DRILL-5937
>             Project: Apache Drill
>          Issue Type: Bug
>          Components: Query Planning &amp; Optimization
>    Affects Versions: 1.8.0
>            Reporter: Pushpendra Jaiswal
>            Priority: Major
>             Fix For: 1.14.0
>
>
> prepare.statement.create_timeout_ms default is 10 seconds but code comment 
> says default should be 10 mins
> The value is by default set to 10000 ms 
> https://github.com/apache/drill/blob/master/exec/java-exec/src/main/java/org/apache/drill/exec/ExecConstants.java#L526
>  
> /**
>    * Timeout for create prepare statement request. If the request exceeds 
> this timeout, then request is timed out.
>    * Default value is 10mins.
>    */



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to