[
https://issues.apache.org/jira/browse/DRILL-6279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16420191#comment-16420191
]
ASF GitHub Bot commented on DRILL-6279:
---------------------------------------
GitHub user kkhatua opened a pull request:
https://github.com/apache/drill/pull/1197
DRILL-6279: UI indicates operators that spilled in-memory data to disk
1. Detect the presence of an operator that has spilled to disk, in the
Operators Overview section of a query's profile page.
2. Introduced API to inject html attributes into a cell. This is used to
inject details about the spill in the avg peak and max peak memory usage
3. Javascript is leveraged to detect spilled operators' HTML elements, and
inject a symbolic font for indicating the operator as having spilt.
4. Mouse-over effect indicates the average and max number of spill cycles
the operator went through.
NOTE: Bootstrap library comes with Glyphicons Halfling Fonts and meets the
Apache license requirements.
http://glyphicons.com/license#halflingsbootstrap
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kkhatua/drill DRILL-6279
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/drill/pull/1197.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1197
----
commit 230d739c05e2f2da93232fe31dec55adf627937e
Author: Kunal Khatua <kkhatua@...>
Date: 2018-03-30T04:58:53Z
DRILL-6279: UI indicates operators that spilled in-memory data to disk
1. Detect the presence of an operator that has spilled to disk, in the
Operators Overview section of a query's profile page.
2. Introduced API to inject html attributes into a cell. This is used to
inject details about the spill in the avg peak and max peak memory usage
3. Javascript is leveraged to detect spilled operators' HTML elements, and
inject a symbolic font for indicating the operator as having spilt.
4. Mouse-over effect indicates the average and max number of spill cycles
the operator went through.
commit 5641e713888db6e3e028a5749bd902dc3bdc6562
Author: Kunal Khatua <kkhatua@...>
Date: 2018-03-26T05:05:06Z
Addition of Bootstrap's Glyphicons
As part of the Bootstrap's components, this meets Apache License criteria
----
> Web UI should indicate when operators have spilled in-memory data to disk
> -------------------------------------------------------------------------
>
> Key: DRILL-6279
> URL: https://issues.apache.org/jira/browse/DRILL-6279
> Project: Apache Drill
> Issue Type: Sub-task
> Affects Versions: 1.13.0
> Reporter: Kunal Khatua
> Assignee: Kunal Khatua
> Priority: Major
> Fix For: 1.14.0
>
>
> Currently, there is no indication of when an operator is spilling to disk,
> which would help explain a slow running query.
> Suggestions are welcome, but the current proposal is to simply update the
> Operators Overview section to show average and max spill cycles, preferrably,
> with a color code (or formatting).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
