[
https://issues.apache.org/jira/browse/DRILL-6294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16421016#comment-16421016
]
ASF GitHub Bot commented on DRILL-6294:
---------------------------------------
Github user chunhui-shi commented on a diff in the pull request:
https://github.com/apache/drill/pull/1198#discussion_r178395314
--- Diff:
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillResultSetImpl.java ---
@@ -1142,16 +1142,8 @@ public void moveToCurrentRow() throws SQLException {
}
@Override
- public AvaticaStatement getStatement() {
- try {
- throwIfClosed();
- } catch (AlreadyClosedSqlException e) {
- // Can't throw any SQLException because AvaticaConnection's
- // getStatement() is missing "throws SQLException".
- throw new RuntimeException(e.getMessage(), e);
- } catch (SQLException e) {
- throw new RuntimeException(e.getMessage(), e);
- }
+ public AvaticaStatement getStatement() throws SQLException {
+ throwIfClosed();
--- End diff --
Since you are touching this file. You might want to remove not needed
Exceptions for throwIfClosed() method that are derives of SqlException.
> Update Calcite version to 1.16.0
> --------------------------------
>
> Key: DRILL-6294
> URL: https://issues.apache.org/jira/browse/DRILL-6294
> Project: Apache Drill
> Issue Type: Task
> Affects Versions: 1.13.0
> Reporter: Volodymyr Vysotskyi
> Assignee: Volodymyr Vysotskyi
> Priority: Major
> Fix For: 1.14.0
>
>
> Upgrade to Calcite 16 version.
> From the last upgrade to Calcite 15, several commits were left in
> Drill-Calcite fork. Since no additional work was done to move those commits
> from the fork, they will be placed on top of Calcite 16.
> Status from the last upgrade:
>
> [https://docs.google.com/document/d/1Lqk9NoKQviz0YimBmov4z1pui7QjJGjDVwMa1p0emPk/edit#heading=h.i3rowg20vxv4]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
