[ https://issues.apache.org/jira/browse/DRILL-4091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16422981#comment-16422981 ]
ASF GitHub Bot commented on DRILL-4091: --------------------------------------- Github user ChrisSandison commented on a diff in the pull request: https://github.com/apache/drill/pull/258#discussion_r178619522 --- Diff: contrib/gis/src/main/java/org/apache/drill/exec/expr/fn/impl/gis/STXFunc.java --- @@ -0,0 +1,64 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.drill.exec.expr.fn.impl.gis; + +import java.sql.Types; + +import javax.inject.Inject; + +import org.apache.drill.exec.expr.DrillSimpleFunc; +import org.apache.drill.exec.expr.annotations.FunctionTemplate; +import org.apache.drill.exec.expr.annotations.Output; +import org.apache.drill.exec.expr.annotations.Param; +import org.apache.drill.exec.expr.holders.Float8Holder; +import org.apache.drill.exec.expr.holders.VarBinaryHolder; + +import com.esri.core.geometry.Geometry.Type; +import com.esri.core.geometry.ogc.OGCPoint; + +import io.netty.buffer.DrillBuf; + +@FunctionTemplate(name = "st_x", scope = FunctionTemplate.FunctionScope.SIMPLE, + nulls = FunctionTemplate.NullHandling.NULL_IF_NULL) +public class STXFunc implements DrillSimpleFunc { + @Param + VarBinaryHolder geomParam; + + @Output + Float8Holder out; + + @Inject + DrillBuf buffer; + + public void setup() { + } + + public void eval() { + + com.esri.core.geometry.ogc.OGCGeometry geom; + + geom = com.esri.core.geometry.ogc.OGCGeometry + .fromBinary(geomParam.buffer.nioBuffer(geomParam.start, geomParam.end - geomParam.start)); + + if(geom != null && geom.geometryType().equals("Point")){ + out.value = ((com.esri.core.geometry.ogc.OGCPoint) geom).X(); + } else { + out.value = Double.NaN; --- End diff -- @cgivre it looks like the assigning of `NaN` is breaking the test suite. Is this the behaviour, or could this be the default null handling that is provided? Ditto for other times this is assigned > Support more functions in gis contrib module > -------------------------------------------- > > Key: DRILL-4091 > URL: https://issues.apache.org/jira/browse/DRILL-4091 > Project: Apache Drill > Issue Type: Improvement > Components: Functions - Drill > Reporter: Karol Potocki > Assignee: Karol Potocki > Priority: Major > > Support for commonly used gis functions in gis contrib module: relate, > contains, crosses, intersects, touches, difference, disjoint, buffer, union > etc. -- This message was sent by Atlassian JIRA (v7.6.3#76005)