[ 
https://issues.apache.org/jira/browse/DRILL-6289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16431208#comment-16431208
 ] 

ASF GitHub Bot commented on DRILL-6289:
---------------------------------------

Github user kkhatua commented on a diff in the pull request:

    https://github.com/apache/drill/pull/1203#discussion_r180226226
  
    --- Diff: exec/java-exec/src/main/resources/rest/index.ftl ---
    @@ -289,14 +314,94 @@
                       });
                   }
               }
    -      </#if>
    +
    +          function remoteShutdown(button,host) {
    +              var url = location.protocol + "//" + host + 
"/gracefulShutdown";
    +              var result = $.ajax({
    +                    type: 'POST',
    +                    url: url,
    +                    contentType : 'text/plain',
    +                    complete: function(data) {
    +                        alert(data.responseJSON["response"]);
    +                        button.prop('disabled',true).css('opacity',0.5);
    +                    }
    +              });
    +          }
    +          </#if>
           function getRequestUrl(requestPath) {
                 var protocol = location.protocol;
                 var host = location.host;
                 var url = protocol + "//" + host + requestPath;
                 return url;
           }
    -    </script>
    +
    +      //Iterates through all the nodes for update
    +      function reloadMetrics() {
    +          for (i = 1; i <= size; i++) {
    +              var address = 
$("#row-"+i).find("#address").contents().get(0).nodeValue.trim();
    +              var httpPort = 
$("#row-"+i).find("#httpPort").contents().get(0).nodeValue.trim();
    +              updateMetricsHtml(address, httpPort, i);
    +          }
    +      }
    +
    +      //Update memory
    +      //TODO: HTTPS?
    +      function updateMetricsHtml(drillbit,webport,idx) {
    +        var result = $.ajax({
    +          type: 'GET',
    --- End diff --
    
    Good catch. I believe we'll get invalid certificate errors since the 
certificate exceptions most likely are not added. 
    So the question I have then is whether we should disable making **any** 
remote HTTPS calls at all, or take a chance with the hope that the invalid 
certificate +might+ have been added? 


> Cluster view should show more relevant information
> --------------------------------------------------
>
>                 Key: DRILL-6289
>                 URL: https://issues.apache.org/jira/browse/DRILL-6289
>             Project: Apache Drill
>          Issue Type: Improvement
>          Components: Web Server
>    Affects Versions: 1.13.0
>            Reporter: Kunal Khatua
>            Assignee: Kunal Khatua
>            Priority: Major
>             Fix For: 1.14.0
>
>   Original Estimate: 168h
>  Remaining Estimate: 168h
>
> When fixing DRILL-6224, I noticed that the same information can be very 
> useful to have in the cluster view shown on a Drillbit's homepage. 
> The proposal is to show the following:
> # Heap Memory in use
> # Direct Memory (actively) in use - Since we're not able to get the total 
> memory held by Netty at the moment, but only what is currently allocated to 
> running queries
> # Process CPU
> # Average (System) Load Factor 
> Information such as the port numbers don't help much during general cluster 
> health, so it might be worth removing this information if more real-estate is 
> needed.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to