[
https://issues.apache.org/jira/browse/DRILL-6289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16436564#comment-16436564
]
ASF GitHub Bot commented on DRILL-6289:
---------------------------------------
Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/1203#discussion_r181251700
--- Diff: exec/java-exec/src/main/resources/rest/index.ftl ---
@@ -79,9 +91,14 @@
</span>
</td>
<td id="status" >${drillbit.getState()}</td>
+ <!-- #if (model.shouldShowAdminInfo() ||
!model.isAuthEnabled()) -->
<#if (model.shouldShowAdminInfo() ||
!model.isAuthEnabled()) && drillbit.isCurrent() >
<td>
- <button type="button" id="shutdown"
onClick="shutdown($(this));"> SHUTDOWN </button>
+ <button type="button" id="shutdown"
onClick="shutdown($(this));"><span class="glyphicon glyphicon-off"></span>
SHUTDOWN </button>
+ </td>
+ <#elseif (model.shouldShowAdminInfo() ||
!model.isAuthEnabled()) && !drillbit.isCurrent() >
+ <td>
--- End diff --
the elseif check should be `(!model.isAuthEnabled && !drillbit.isCurrent()
&& check to see if not https)`
FYI - On a bigger note I think it will be cumbersome and error prone to
implement remote shutdown when security is enabled using WebClient side
changes. There are few options which where discussed on how to achieve it,
please see: [DRILL-6244](https://issues.apache.org/jira/browse/DRILL-6244). I
would prefer if we can be consistent to do remote shutdown in same way for both
secure and unsecure case.
> Cluster view should show more relevant information
> --------------------------------------------------
>
> Key: DRILL-6289
> URL: https://issues.apache.org/jira/browse/DRILL-6289
> Project: Apache Drill
> Issue Type: Improvement
> Components: Web Server
> Affects Versions: 1.13.0
> Reporter: Kunal Khatua
> Assignee: Kunal Khatua
> Priority: Major
> Fix For: 1.14.0
>
> Original Estimate: 168h
> Remaining Estimate: 168h
>
> When fixing DRILL-6224, I noticed that the same information can be very
> useful to have in the cluster view shown on a Drillbit's homepage.
> The proposal is to show the following:
> # Heap Memory in use
> # Direct Memory (actively) in use - Since we're not able to get the total
> memory held by Netty at the moment, but only what is currently allocated to
> running queries
> # Process CPU
> # Average (System) Load Factor
> Information such as the port numbers don't help much during general cluster
> health, so it might be worth removing this information if more real-estate is
> needed.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
