[
https://issues.apache.org/jira/browse/DRILL-6289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16442933#comment-16442933
]
ASF GitHub Bot commented on DRILL-6289:
---------------------------------------
Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/1203#discussion_r182510967
--- Diff: exec/java-exec/src/main/resources/rest/index.ftl ---
@@ -79,11 +94,15 @@
</span>
</td>
<td id="status" >${drillbit.getState()}</td>
- <#if (model.shouldShowAdminInfo() ||
!model.isAuthEnabled()) && drillbit.isCurrent() >
+ <td class="uptime" >Not Available</td>
<td>
- <button type="button" id="shutdown"
onClick="shutdown($(this));"> SHUTDOWN </button>
- </td>
+ <#if (model.shouldShowAdminInfo() ||
!model.isAuthEnabled()) && (drillbit.isCurrent() ||
!model.isUserEncryptionEnabled()) >
--- End diff --
Please re-visit this condition. `IsUserEncryptionEnabled()` only checks for
encryption between JDBC/ODBC client to Drillbit path not for Https. You have to
check it using protocol.
You can put the check something like below:
```
if(model.shouldShowAdminInfo() && (drillbit.isCurrent() ||
(!model.isAuthEnabled() && location.protocol != https))) {
showShutdownButton();
}
```
> Cluster view should show more relevant information
> --------------------------------------------------
>
> Key: DRILL-6289
> URL: https://issues.apache.org/jira/browse/DRILL-6289
> Project: Apache Drill
> Issue Type: Improvement
> Components: Web Server
> Affects Versions: 1.13.0
> Reporter: Kunal Khatua
> Assignee: Kunal Khatua
> Priority: Major
> Fix For: 1.14.0
>
> Original Estimate: 168h
> Remaining Estimate: 168h
>
> When fixing DRILL-6224, I noticed that the same information can be very
> useful to have in the cluster view shown on a Drillbit's homepage.
> The proposal is to show the following:
> # Heap Memory in use
> # Direct Memory (actively) in use - Since we're not able to get the total
> memory held by Netty at the moment, but only what is currently allocated to
> running queries
> # Process CPU
> # Average (System) Load Factor
> Information such as the port numbers don't help much during general cluster
> health, so it might be worth removing this information if more real-estate is
> needed.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
