[ 
https://issues.apache.org/jira/browse/DRILL-6272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16445661#comment-16445661
 ] 

ASF GitHub Bot commented on DRILL-6272:
---------------------------------------

Github user arina-ielchiieva commented on the issue:

    https://github.com/apache/drill/pull/1225
  
    @vrozov addressed code review comments.
    Regarding embedded maven, I have considered this option but using native 
Java to generate jars is more convenient. First of all, for the tests we need 
different jars, with and without resource file, classes. Doing it in Java 
allows to store less config and template files. Also we do not depend from any 
build tool. Plus it much easier to debug and run test using IDE or maven. I 
suggest we leave the current approach.



> Remove binary jars files from source distribution
> -------------------------------------------------
>
>                 Key: DRILL-6272
>                 URL: https://issues.apache.org/jira/browse/DRILL-6272
>             Project: Apache Drill
>          Issue Type: Task
>            Reporter: Vlad Rozov
>            Assignee: Arina Ielchiieva
>            Priority: Critical
>             Fix For: 1.14.0
>
>
> Per [~vrozov] the source distribution contains binary jar files under 
> exec/java-exec/src/test/resources/jars



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to