[
https://issues.apache.org/jira/browse/DRILL-6336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16448995#comment-16448995
]
ASF GitHub Bot commented on DRILL-6336:
---------------------------------------
Github user vrozov commented on the issue:
https://github.com/apache/drill/pull/1235
There is no need to expose implementation details as part of the class API.
Whether `DebugStringBuilder` uses `PrintWriter.print()` or something else to
implement `append()` must be hidden from `DebugStringBuilder` consumers. Method
name should never depend on details of implementation as the implementation may
change, but API should not.
> Inconsistent method name.
> -------------------------
>
> Key: DRILL-6336
> URL: https://issues.apache.org/jira/browse/DRILL-6336
> Project: Apache Drill
> Issue Type: Improvement
> Reporter: KuiLIU
> Priority: Major
> Attachments: rename-method.patch
>
>
> The following method is named "append", but its body code is an method
> invocation "writer.print( s )". The method should be named "print".
> {code:java}
> public DebugStringBuilder append( String s ) {
> writer.print( s );
> return this;
> }
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
