[ 
https://issues.apache.org/jira/browse/DRILL-6331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16449489#comment-16449489
 ] 

ASF GitHub Bot commented on DRILL-6331:
---------------------------------------

Github user vdiravka commented on a diff in the pull request:

    https://github.com/apache/drill/pull/1214#discussion_r183647695
  
    --- Diff: 
contrib/storage-hive/core/src/main/java/org/apache/drill/exec/planner/sql/logical/ConvertHiveParquetScanToDrillParquetScan.java
 ---
    @@ -166,25 +171,43 @@ public boolean matches(RelOptRuleCall call) {
       @Override
       public void onMatch(RelOptRuleCall call) {
         try {
    -      final DrillScanRel hiveScanRel = (DrillScanRel) call.rel(0);
    +      final DrillScanRel hiveScanRel = call.rel(0);
           final HiveScan hiveScan = (HiveScan) hiveScanRel.getGroupScan();
     
           final PlannerSettings settings = 
PrelUtil.getPlannerSettings(call.getPlanner());
           final String partitionColumnLabel = 
settings.getFsPartitionColumnLabel();
     
           final Table hiveTable = hiveScan.getHiveReadEntry().getTable();
    -      checkForUnsupportedDataTypes(hiveTable);
    +      final HiveReadEntry hiveReadEntry = hiveScan.getHiveReadEntry();
    +
    +      final HiveMetadataProvider hiveMetadataProvider = new 
HiveMetadataProvider(hiveScan.getUserName(), hiveReadEntry, 
hiveScan.getStoragePlugin().getHiveConf());
    --- End diff --
    
    line break


> Parquet filter pushdown does not support the native hive reader
> ---------------------------------------------------------------
>
>                 Key: DRILL-6331
>                 URL: https://issues.apache.org/jira/browse/DRILL-6331
>             Project: Apache Drill
>          Issue Type: Improvement
>          Components: Storage - Hive
>    Affects Versions: 1.13.0
>            Reporter: Arina Ielchiieva
>            Assignee: Arina Ielchiieva
>            Priority: Major
>             Fix For: 1.14.0
>
>
> Initially HiveDrillNativeParquetGroupScan was based mainly on HiveScan, the 
> core difference between them was
> that HiveDrillNativeParquetScanBatchCreator was creating ParquetRecordReader 
> instead of HiveReader.
> This allowed to read Hive parquet files using Drill native parquet reader but 
> did not expose Hive data to Drill optimizations.
> For example, filter push down, limit push down, count to direct scan 
> optimizations.
> Hive code had to be refactored to use the same interfaces as 
> ParquestGroupScan in order to be exposed to such optimizations.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to