[
https://issues.apache.org/jira/browse/DRILL-5870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16451597#comment-16451597
]
Paul Rogers commented on DRILL-5870:
------------------------------------
Map support has long been available in the row set readers and writers. See the
various test cases for examples of use. In particular, see
[TestResultSetLoaderMaps.java|https://github.com/apache/drill/blob/master/exec/java-exec/src/test/java/org/apache/drill/exec/physical/rowSet/impl/TestResultSetLoaderMaps.java].
This is for the result set loader, but the RowSetWriter API is identical.
The row set builder has simple interfaces for all types. I've been spending the
last four months moving the pieces into the code one PR at a time. We are about
two 1/2 PRs away. The open one is ready to commit, then there is a refactoring
of the result set loader, then finally I'll drop in the Union, (non-repeated)
List and Repeated List support.
If at all possible, please don't do a new implementation. The solution is VERY
complex for Union and List; no reason for you to struggle through it.
If you need the functionality short term, you can take a look at either my
[DRILL-6314|https://github.com/paul-rogers/drill/tree/DRILL-6314] or
[RowSetRev4|https://github.com/paul-rogers/drill/tree/RowSetRev4] branches.
DRILL-6314 has all the reader, writer and result set loader changes. RowSetRev4
has the full set of changes including scan operator, JSON reader, etc.
Or, even better, maybe help review the PRs as they arrive: you'll help me get
the code in and learn the internals of the solution. Plus, maybe, with the
experience you've accumulated, you'll spot some ways we can improve the
solution.
All of this is fully explained in [this Wiki
post|https://github.com/paul-rogers/drill/wiki/Batch-Handling-Upgrades].
> Simplify creating list and map values for the row set builder
> -------------------------------------------------------------
>
> Key: DRILL-5870
> URL: https://issues.apache.org/jira/browse/DRILL-5870
> Project: Apache Drill
> Issue Type: Improvement
> Reporter: Timothy Farkas
> Assignee: Timothy Farkas
> Priority: Minor
>
> [~Paul.Rogers] Did you or Padma do this already? If not I have some time to
> work on this now. I think I see the code to do this for lists with
> ArrayWriter but not for Maps. Anyhow let me know.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
