[jira] [Commented] (DRILL-6364) WebUI does not cleanly handle shutdown and state toggling when Drillbits go on and offline

[ASF GitHub Bot (JIRA)]

    [ 
https://issues.apache.org/jira/browse/DRILL-6364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16460594#comment-16460594
 ] 

ASF GitHub Bot commented on DRILL-6364:
---------------------------------------

Github user sohami commented on a diff in the pull request:

    https://github.com/apache/drill/pull/1241#discussion_r185392204
  
    --- Diff: exec/java-exec/src/main/resources/rest/index.ftl ---
    @@ -103,14 +105,14 @@
                     </td>
                     <td id="status" >${drillbit.getState()}</td>
                     <td class="uptime" >Not Available</td>
    -                  <td>
    -                <#if ( model.shouldShowAdminInfo() &&  ( 
drillbit.isCurrent() || ( !model.isAuthEnabled() && location.protocol != 
"https" ))) >
    -                      <button type="button" id="shutdown" 
onClick="shutdown($(this), 
'${drillbit.getAddress()}:${drillbit.getHttpPort()}');">
    -                <#else>
    +                <td>
    +                  <#if ( model.shouldShowAdminInfo() || 
!model.isAuthEnabled() || drillbit.isCurrent() ) >
    --- End diff --
    
    I think what is required here is to show shutdown button both for local and 
remote Drillbits only to admin users. But the button will be hidden and not 
enabled to click. Then later logic in [line 
317](https://github.com/kkhatua/drill/blob/ab3e8619c6259803eb362be290a3a3605839a194/exec/java-exec/src/main/resources/rest/index.ftl#L317)
 will enable the button.
    
    But with current check even if user is non-Admin it will show the button. 
Check will be as below:
    
    ```
    <#if (!model.isAuthEnabled() || model.shouldShowAdminInfo())>
        <#if drillbit.isCurrent()>
            <button type="button" id="shutdown" onClick="shutdown($(this));" 
disabled="true" style="opacity:0.5;cursor:not-allowed;">
        <#else>
            <button type="button" id="shutdown" title="Drillbit cannot be 
shutdown remotely" disabled="true" style="opacity:0.5;cursor:not-allowed;">
        </#if>
    </#if>
    ```
    
    Please test with auth enabled and non-admin user too. Sharing example 
snapshot below.
    
    <img width="1271" alt="screen shot 2018-05-01 at 9 42 37 pm" 
src="https://user-images.githubusercontent.com/22159459/39505653-a37c1326-4d88-11e8-99c7-d8ab5495c7cb.png";>



> WebUI does not cleanly handle shutdown and state toggling when Drillbits go 
> on and offline
> ------------------------------------------------------------------------------------------
>
>                 Key: DRILL-6364
>                 URL: https://issues.apache.org/jira/browse/DRILL-6364
>             Project: Apache Drill
>          Issue Type: Bug
>          Components: Web Server
>            Reporter: Kunal Khatua
>            Assignee: Kunal Khatua
>            Priority: Major
>             Fix For: 1.14.0
>
>
> When the webpage is loaded the first time, the shutdown button is enabled by 
> default, which might not be correct, since scenarios like HTTPS, etc does not 
> support this for remote bits. (i.e the user needs to navigate to that node's 
> UI for shutting it down). 
> Similarly, when a previously unseen Drillbit comes online, the node will not 
> be rendered until the page is refreshed by the user. 
> Lastly, if the node from whom the UI page was served goes down, the status 
> update for the rest of the cluster is not updated.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)