[ 
https://issues.apache.org/jira/browse/DRILL-6272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16464828#comment-16464828
 ] 

ASF GitHub Bot commented on DRILL-6272:
---------------------------------------

arina-ielchiieva commented on issue #1225: DRILL-6272: Refactor dynamic UDFs 
and function initializer tests to g…
URL: https://github.com/apache/drill/pull/1225#issuecomment-386817536
 
 
   @vrozov done all the changes. One point regarding using current drill 
snapshot version as dependency when building jars. I decided to leave it 
hard-coded to 1.13.0  because `mvn clean install` with clean local maven repo 
succeeds since 1.13.0 is downloaded from central mvn repo. If we use 
1.14.0-SNAPSHOT, build fails because this version is absent in central maven 
repo and in local, in other words to run unit tests on new snapshot version, we 
would have to build the project first which is not acceptable especially  since 
currently we are not obliged to it.
   Left the following comment in code, in case somebody what to build jars with 
current version:
   ```
         // uncomment to build with current Drill version
         // params.add("-Ddrill.version=" + DrillVersionInfo.getVersion());
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


> Remove binary jars files from source distribution
> -------------------------------------------------
>
>                 Key: DRILL-6272
>                 URL: https://issues.apache.org/jira/browse/DRILL-6272
>             Project: Apache Drill
>          Issue Type: Task
>            Reporter: Vlad Rozov
>            Assignee: Arina Ielchiieva
>            Priority: Critical
>             Fix For: 1.14.0
>
>
> Per [~vrozov] the source distribution contains binary jar files under 
> exec/java-exec/src/test/resources/jars



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to