[
https://issues.apache.org/jira/browse/DRILL-6386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16467781#comment-16467781
]
ASF GitHub Bot commented on DRILL-6386:
---------------------------------------
ilooner commented on issue #1252: DRILL-6386: Disallowed unused imports and
removed them.
URL: https://github.com/apache/drill/pull/1252#issuecomment-387492658
@arina-ielchiieva Addressing your questions:
1. This doesn't cover import order. From what I vaguely remember with Apache
Apex, import order was a highly controversial topic. I want to avoid that
discussion for now and get everybody comfortable with adding more checkstyle
checks bit by bit. Once people are more comfortable with stricter checkstyle
checks I am hoping a discussion about adding import order checks can reach a
consensus quicker.
2. I will refactor into two commits as you suggested.
3. I wasn't planning on adding any documentation about this now since the
checkstyle errors are pretty descriptive. However, I was planning on writing a
Checkstyle.md which will explain how to import a checkstyle.xml into your IDE
so that you can see checkstyle warnings within your IDE as well as autoformat
your code according to Drill's checkstyle config. Chandni figured out all these
things for Apache Apex, but I don't think it's documented anywhere. So I'll
sync up with her and get it written down as part of a separate Jira.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Disallow Unused Imports In Checkstyle
> -------------------------------------
>
> Key: DRILL-6386
> URL: https://issues.apache.org/jira/browse/DRILL-6386
> Project: Apache Drill
> Issue Type: Improvement
> Reporter: Timothy Farkas
> Assignee: Timothy Farkas
> Priority: Major
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
