[
https://issues.apache.org/jira/browse/DRILL-6249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16468455#comment-16468455
]
ASF GitHub Bot commented on DRILL-6249:
---------------------------------------
paul-rogers commented on a change in pull request #1251: DRILL-6249: Adding
more unit testing documentation.
URL: https://github.com/apache/drill/pull/1251#discussion_r186934852
##########
File path: README.md
##########
@@ -20,7 +20,7 @@ Please see the [Apache Drill
Website](http://drill.apache.org/) or the [Apache D
## Join the community!
-Apache Drill is an Apache Foundation project and is seeking all types of
contributions. Please say hello on the Apache Drill mailing list or join our
Google Hangouts for more information. (More information can be found at the
Apache Drill website).
+Apache Drill is an Apache Foundation project and is seeking all types of
contributions. Please say hello on the Apache Drill mailing list or join our
Google Hangouts for more information. (More information can be found at the
Apache Drill website).
Review comment:
Very nice. Maybe split into shorter lines for easier editing commenting.
On the end "mailing list, join our Google Hangouts, or see the Apache Drill
website for more information." Then, enclose "Apache Drill website" in a link
to that website. Maybe have a link for the mail list and hangouts to the
corresponding pages in the Community part of the site.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Add Markdown Docs for Unit Testing and Link to it in README.md
> --------------------------------------------------------------
>
> Key: DRILL-6249
> URL: https://issues.apache.org/jira/browse/DRILL-6249
> Project: Apache Drill
> Issue Type: Improvement
> Reporter: Timothy Farkas
> Assignee: Timothy Farkas
> Priority: Major
> Labels: ready-to-commit
> Fix For: 1.14.0
>
>
> I am working on a presentation about how to use the unit testing utilities in
> Drill. Instead of writing the doc and having it be lost in Google Drive
> somewhere I am going to add a Markdown doc to the drill repo and link to it
> in the README.md. This is appropriate since these docs will only be used by
> developers, and the way we unit test will change as the code changes. So the
> unit testing docs should be kept in the same repo as the code so it can be
> updated and kept in sync with the rest of Drill.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
