[
https://issues.apache.org/jira/browse/DRILL-6348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16468999#comment-16468999
]
ASF GitHub Bot commented on DRILL-6348:
---------------------------------------
sachouche commented on a change in pull request #1237: DRILL-6348: Fixed code
so that Unordered Receiver reports its memory …
URL: https://github.com/apache/drill/pull/1237#discussion_r187091322
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/work/batch/AbstractDataCollector.java
##########
@@ -116,4 +120,16 @@ public void close() throws Exception {
AutoCloseables.close(buffers);
}
+ /** {@inheritDoc} */
+ @Override
+ public BufferAllocator getAllocator() {
+ return this.ownerAllocator;
+ }
+
+ /** {@inheritDoc} */
+ @Override
+ public void setAllocator(BufferAllocator allocator) {
+ this.ownerAllocator = allocator;
Review comment:
I wondered about the same; the only reasons for the caller to pass a null,
is either a bug or allocator unregistration. I guess for now, I'll add an
assert since we do not really need an unregistration step (this will also help
us catch erroneous setting of the allocator).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Unordered Receiver does not report its memory usage
> ---------------------------------------------------
>
> Key: DRILL-6348
> URL: https://issues.apache.org/jira/browse/DRILL-6348
> Project: Apache Drill
> Issue Type: Task
> Components: Execution - Flow
> Reporter: salim achouche
> Assignee: salim achouche
> Priority: Major
> Fix For: 1.14.0
>
>
> The Drill Profile functionality doesn't show any memory usage for the
> Unordered Receiver operator. This is problematic when analyzing OOM
> conditions since we cannot account for all of a query memory usage. This Jira
> is to fix memory reporting for the Unordered Receiver operator.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
