[
https://issues.apache.org/jira/browse/DRILL-6249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16469719#comment-16469719
]
ASF GitHub Bot commented on DRILL-6249:
---------------------------------------
ilooner commented on a change in pull request #1251: DRILL-6249: Adding more
unit testing documentation.
URL: https://github.com/apache/drill/pull/1251#discussion_r187209131
##########
File path: common/src/test/java/org/apache/drill/test/DirTestWatcher.java
##########
@@ -34,7 +34,7 @@
* A {@link DirTestWatcher} is added to a test by declaring it as a JUnit
{@link org.junit.Rule}. A {@link org.junit.Rule} is
* a piece of code that is run before and after every JUnit test marked with
the {@link org.junit.Test} annotation. When the
* {@link DirTestWatcher} is added to a test class the {@link DirTestWatcher}
will create a temp directory before each of your
- * {@link org.junit.Test}s and optionally delete the temp directory after each
of your {@link org.junit.Test}s. The temp directory
+ * {@link org.junit.Test}s and optionally delete the temp directory after each
of your {@link org.junit.Test}s. The <b>base temp directory</b>
Review comment:
It doesn't show the base name. You are right, you have to use `{@link
org.junit.Test Test}`. Updated to do so.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Add Markdown Docs for Unit Testing and Link to it in README.md
> --------------------------------------------------------------
>
> Key: DRILL-6249
> URL: https://issues.apache.org/jira/browse/DRILL-6249
> Project: Apache Drill
> Issue Type: Improvement
> Reporter: Timothy Farkas
> Assignee: Timothy Farkas
> Priority: Major
> Labels: ready-to-commit
> Fix For: 1.14.0
>
>
> I am working on a presentation about how to use the unit testing utilities in
> Drill. Instead of writing the doc and having it be lost in Google Drive
> somewhere I am going to add a Markdown doc to the drill repo and link to it
> in the README.md. This is appropriate since these docs will only be used by
> developers, and the way we unit test will change as the code changes. So the
> unit testing docs should be kept in the same repo as the code so it can be
> updated and kept in sync with the rest of Drill.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
