[
https://issues.apache.org/jira/browse/DRILL-6411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16476643#comment-16476643
]
ASF GitHub Bot commented on DRILL-6411:
---------------------------------------
Ben-Zvi commented on a change in pull request #1260: DRILL-6411: Make batch
memory sizing logs uniform across all operators
URL: https://github.com/apache/drill/pull/1260#discussion_r188474728
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/flatten/FlattenRecordBatch.java
##########
@@ -263,6 +260,8 @@ protected IterOutcome doWork() {
flattenMemoryManager.updateOutgoingStats(outputRecords);
+ logger.debug("BATCH_STATS, outgoing:\n {}", new RecordBatchSizer(this));
Review comment:
Every execution (even when logging does not happen; i.e., above "debug")
does invoke the call "new RecordBatchSizer()", which adds time/memory overhead
(and GC to remove these objects).
Instead -- better surround this logger.debug() call with ``` if
(logger.isDebugEnabled()) { ```
see similar examples elsewhere (e.g. Foreman.java)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Make batch memory sizing logs uniform across all operators
> ----------------------------------------------------------
>
> Key: DRILL-6411
> URL: https://issues.apache.org/jira/browse/DRILL-6411
> Project: Apache Drill
> Issue Type: Bug
> Affects Versions: 1.13.0
> Reporter: Padma Penumarthy
> Assignee: Padma Penumarthy
> Priority: Major
> Fix For: 1.14.0
>
>
> Make batch memory sizing logs uniform across all operators so QA can parse
> and verify easily.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
