[
https://issues.apache.org/jira/browse/DRILL-6375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16483938#comment-16483938
]
ASF GitHub Bot commented on DRILL-6375:
---------------------------------------
vvysotskyi commented on a change in pull request #1256: DRILL-6375 : Support
for ANY_VALUE aggregate function
URL: https://github.com/apache/drill/pull/1256#discussion_r189897847
##########
File path: exec/java-exec/src/main/codegen/data/AggrTypes1.tdd
##########
@@ -88,6 +88,52 @@
{inputType: "Interval", outputType: "NullableInterval", runningType:
"Interval", major: "Date", initialValue: "0"},
{inputType: "NullableInterval", outputType: "NullableInterval",
runningType: "Interval", major: "Date", initialValue: "0"}
]
+ },
+ {className: "AnyValue", funcName: "any_value", types: [
+ {inputType: "Bit", outputType: "NullableBit", runningType: "Bit",
major: "Numeric"},
+ {inputType: "Int", outputType: "NullableInt", runningType: "Int",
major: "Numeric"},
+ {inputType: "BigInt", outputType: "NullableBigInt", runningType:
"BigInt", major: "Numeric"},
+ {inputType: "NullableBit", outputType: "NullableBit", runningType:
"Bit", major: "Numeric"},
+ {inputType: "NullableInt", outputType: "NullableInt", runningType:
"Int", major: "Numeric"},
+ {inputType: "NullableBigInt", outputType: "NullableBigInt",
runningType: "BigInt", major: "Numeric"},
+ {inputType: "Float4", outputType: "NullableFloat4", runningType:
"Float4", major: "Numeric"},
+ {inputType: "Float8", outputType: "NullableFloat8", runningType:
"Float8", major: "Numeric"},
+ {inputType: "NullableFloat4", outputType: "NullableFloat4",
runningType: "Float4", major: "Numeric"},
+ {inputType: "NullableFloat8", outputType: "NullableFloat8",
runningType: "Float8", major: "Numeric"},
+ {inputType: "Date", outputType: "NullableDate", runningType: "Date",
major: "Date", initialValue: "0"},
+ {inputType: "NullableDate", outputType: "NullableDate", runningType:
"Date", major: "Date", initialValue: "0"},
+ {inputType: "TimeStamp", outputType: "NullableTimeStamp", runningType:
"TimeStamp", major: "Date", initialValue: "0"},
+ {inputType: "NullableTimeStamp", outputType: "NullableTimeStamp",
runningType: "TimeStamp", major: "Date", initialValue: "0"},
+ {inputType: "Time", outputType: "NullableTime", runningType: "Time",
major: "Date", initialValue: "0"},
+ {inputType: "NullableTime", outputType: "NullableTime", runningType:
"Time", major: "Date", initialValue: "0"},
+ {inputType: "IntervalDay", outputType: "NullableIntervalDay",
runningType: "IntervalDay", major: "Date", initialValue: "0"},
+ {inputType: "NullableIntervalDay", outputType: "NullableIntervalDay",
runningType: "IntervalDay", major: "Date", initialValue: "0"},
+ {inputType: "IntervalYear", outputType: "NullableIntervalYear",
runningType: "IntervalYear", major: "Date", initialValue: "0"},
+ {inputType: "NullableIntervalYear", outputType: "NullableIntervalYear",
runningType: "IntervalYear", major: "Date", initialValue: "0"},
+ {inputType: "Interval", outputType: "NullableInterval", runningType:
"Interval", major: "Date", initialValue: "0"},
+ {inputType: "NullableInterval", outputType: "NullableInterval",
runningType: "Interval", major: "Date", initialValue: "0"},
+ {inputType: "VarChar", outputType: "NullableVarChar", runningType:
"VarChar", major: "VarBytes", initialValue: ""},
+ {inputType: "NullableVarChar", outputType: "NullableVarChar",
runningType: "VarChar", major: "VarBytes", initialValue: ""},
+ {inputType: "VarBinary", outputType: "NullableVarBinary", runningType:
"VarBinary", major: "VarBytes"},
+ {inputType: "NullableVarBinary", outputType: "NullableVarBinary",
runningType: "VarBinary", major: "VarBytes"}
+ {inputType: "List", outputType: "List", runningType: "List", major:
"Complex"}
+ {inputType: "Map", outputType: "Map", runningType: "Map", major:
"Complex"}
+ {inputType: "RepeatedBit", outputType: "RepeatedNullableBit",
runningType: "RepeatedBit", major: "Complex"},
Review comment:
These names `RepeatedNullable` types are a little bit confusing. Data mode
can be either repeated or nullable, but not repeated and nullable
simultaneously. Could you please rename it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> ANY_VALUE aggregate function
> ----------------------------
>
> Key: DRILL-6375
> URL: https://issues.apache.org/jira/browse/DRILL-6375
> Project: Apache Drill
> Issue Type: New Feature
> Components: Functions - Drill
> Affects Versions: 1.13.0
> Reporter: Gautam Kumar Parai
> Assignee: Gautam Kumar Parai
> Priority: Major
> Fix For: 1.14.0
>
>
> We had discussions on the Apache Calcite [1] and Apache Drill [2] mailing
> lists regarding an equivalent for DISTINCT ON. The community seems to prefer
> the ANY_VALUE. This Jira is a placeholder for implementing the ANY_VALUE
> aggregate function in Apache Drill. We should also eventually contribute it
> to Apache Calcite.
> [1]https://lists.apache.org/thread.html/f2007a489d3a5741875bcc8a1edd8d5c3715e5114ac45058c3b3a42d@%3Cdev.calcite.apache.org%3E
> [2]https://lists.apache.org/thread.html/2517eef7410aed4e88b9515f7e4256335215c1ad39a2676a08d21cb9@%3Cdev.drill.apache.org%3E
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
