[
https://issues.apache.org/jira/browse/DRILL-6436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16486558#comment-16486558
]
ASF GitHub Bot commented on DRILL-6436:
---------------------------------------
vrozov commented on a change in pull request #1282: DRILL-6436: Storage Plugin
to have name and context moved to Abstract…
URL: https://github.com/apache/drill/pull/1282#discussion_r190100026
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/store/AbstractStoragePlugin.java
##########
@@ -29,13 +29,20 @@
import org.apache.drill.exec.planner.PlannerPhase;
import com.google.common.collect.ImmutableSet;
+import org.apache.drill.exec.server.DrillbitContext;
/** Abstract class for StorePlugin implementations.
* See StoragePlugin for description of the interface intent and its methods.
*/
public abstract class AbstractStoragePlugin implements StoragePlugin {
- protected AbstractStoragePlugin() { }
+ protected final DrillbitContext context;
+ final String name;
Review comment:
+1. Both `context` and `name` should be `private` (`protected` is also an
option as both are `final`).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Store context and name in AbstractStoragePlugin instead of replicating fields
> in each StoragePlugin
> ---------------------------------------------------------------------------------------------------
>
> Key: DRILL-6436
> URL: https://issues.apache.org/jira/browse/DRILL-6436
> Project: Apache Drill
> Issue Type: Improvement
> Reporter: Timothy Farkas
> Assignee: Timothy Farkas
> Priority: Major
> Fix For: 1.14.0
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
