[
https://issues.apache.org/jira/browse/DRILL-6373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16494285#comment-16494285
]
ASF GitHub Bot commented on DRILL-6373:
---------------------------------------
paul-rogers commented on issue #1244: DRILL-6373: Refactor Result Set Loader
for Union, List support
URL: https://github.com/apache/drill/pull/1244#issuecomment-392947880
Thanks @ppadma! If you can explain how to reproduce the issue without using
the full functional tests, I can take a look.
In case it leads to anything... Earlier changes around `MaterializedField`
did try to keep the various views of data in sync. The map's
`MaterializedField` is supposed to contain, as children, all the map members.
This means that changes to any map field requires a matching change to the
children. This didn't always happen, leading to bugs that earlier PRs attempted
to fix. Not sure if that has an impact here.
The other question is whether the partition sender is the only code that
calls the `clone()` method. Do we have unit tests for that method?
Is there some interaction in cloning that reaches back into the original
child list? A quick scan of the code didn't suggest any, which is why I wonder
if the change occurs in another thread; perhaps triggered as a result of recent
fixes in the partitioned sender.
Please let us know what you find, then I'd be happy to fix it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Refactor the Result Set Loader to prepare for Union, List support
> -----------------------------------------------------------------
>
> Key: DRILL-6373
> URL: https://issues.apache.org/jira/browse/DRILL-6373
> Project: Apache Drill
> Issue Type: Improvement
> Affects Versions: 1.13.0
> Reporter: Paul Rogers
> Assignee: Paul Rogers
> Priority: Major
> Fix For: 1.14.0
>
>
> As the next step in merging the "batch sizing" enhancements, refactor the
> {{ResultSetLoader}} and related classes to prepare for Union and List
> support. This fix follows the refactoring of the column accessors for the
> same purpose. Actual Union and List support is to follow in a separate PR.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
