[
https://issues.apache.org/jira/browse/DRILL-6446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16495750#comment-16495750
]
ASF GitHub Bot commented on DRILL-6446:
---------------------------------------
parthchandra commented on a change in pull request #1293: DRILL-6446: Support
for EMIT outcome in TopN
URL: https://github.com/apache/drill/pull/1293#discussion_r191936372
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/svremover/AbstractSV4Copier.java
##########
@@ -22,10 +22,12 @@
import org.apache.drill.exec.record.VectorContainer;
import org.apache.drill.exec.record.VectorWrapper;
import org.apache.drill.exec.record.selection.SelectionVector4;
-import org.apache.drill.exec.vector.ValueVector;
public abstract class AbstractSV4Copier extends AbstractCopier {
- protected ValueVector[][] vvIn;
+ // Storing VectorWrapper reference instead of ValueVector[]. With EMIT
outcome support underlying operator
+ // operator can generate multiple output batches with no schema changes
which will change the ValueVector[]
+ // reference but not VectorWrapper reference.
+ protected VectorWrapper<?>[] vvIn;
Review comment:
Does this require a change to RemovingRecordBatch()?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Support for EMIT outcome in TopN
> --------------------------------
>
> Key: DRILL-6446
> URL: https://issues.apache.org/jira/browse/DRILL-6446
> Project: Apache Drill
> Issue Type: Task
> Components: Execution - Relational Operators
> Reporter: Sorabh Hamirwasia
> Assignee: Sorabh Hamirwasia
> Priority: Major
> Fix For: 1.14.0
>
>
> With Lateral and Unnest if TopN is present in the sub-query, then it needs to
> handle the EMIT outcome correctly. This means when a EMIT is received then
> perform the TopN operation on the records buffered so far and produce output
> with it. After EMIT TopN should refresh it's state and again work on next
> batches of incoming record unless an EMIT is seen again.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
