[
https://issues.apache.org/jira/browse/DRILL-4069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16497355#comment-16497355
]
ASF GitHub Bot commented on DRILL-4069:
---------------------------------------
ilooner closed pull request #352: DRILL-4069: Enable RPC thread offload by
default
URL: https://github.com/apache/drill/pull/352
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/exec/rpc/src/main/java/org/apache/drill/exec/rpc/RpcBus.java
b/exec/rpc/src/main/java/org/apache/drill/exec/rpc/RpcBus.java
index acfb862204..69a44add76 100644
--- a/exec/rpc/src/main/java/org/apache/drill/exec/rpc/RpcBus.java
+++ b/exec/rpc/src/main/java/org/apache/drill/exec/rpc/RpcBus.java
@@ -57,7 +57,7 @@
final org.slf4j.Logger logger =
org.slf4j.LoggerFactory.getLogger(this.getClass());
private static final OutboundRpcMessage PONG = new
OutboundRpcMessage(RpcMode.PONG, 0, 0, Acks.OK);
- private static final boolean ENABLE_SEPARATE_THREADS =
"true".equals(System.getProperty("drill.enable_rpc_offload"));
+ private static final boolean DISABLE_SEPARATE_THREADS =
"false".equals(System.getProperty("drill.enable_rpc_offload"));
protected final CoordinationQueue queue = new CoordinationQueue(16, 16);
@@ -262,7 +262,7 @@ public void execute(Runnable command) {
public InboundHandler(C connection) {
super();
this.connection = connection;
- final Executor underlyingExecutor = ENABLE_SEPARATE_THREADS ?
rpcConfig.getExecutor() : new SameExecutor();
+ final Executor underlyingExecutor = DISABLE_SEPARATE_THREADS ? new
SameExecutor() : rpcConfig.getExecutor();
this.exec = new RpcEventHandler(underlyingExecutor);
}
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Enable RPC Thread Offload by default
> ------------------------------------
>
> Key: DRILL-4069
> URL: https://issues.apache.org/jira/browse/DRILL-4069
> Project: Apache Drill
> Issue Type: Bug
> Components: Execution - RPC
> Reporter: Jacques Nadeau
> Assignee: Sudheesh Katkam
> Priority: Major
>
> Once we enabled RPC thread offload, we saw concurrency regressions DRILL-4041
> and DRILL-4057. The regressions appear to be unrelated to, but exposed by the
> thread offload. To simplify things, we disabled the RPC thread offload by
> default. This is the tracking issue to fix the underlying concurrency bug(s).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
