[
https://issues.apache.org/jira/browse/DRILL-4411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16497359#comment-16497359
]
ASF GitHub Bot commented on DRILL-4411:
---------------------------------------
ilooner commented on issue #381: DRILL-4411: hash join should limit batch based
on size and number of records
URL: https://github.com/apache/drill/pull/381#issuecomment-393719467
@minji-kim Thanks for putting the effort into making this change.
Unfortunately a sophisticated version of this was recently completed in this PR
https://github.com/apache/drill/pull/1227 and will be merged soon. Since the
objectives of the two changes were the same I will close this PR. Sorry that
your change did not receive any attention earlier.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> HashJoin should not only depend on number of records, but also on size
> ----------------------------------------------------------------------
>
> Key: DRILL-4411
> URL: https://issues.apache.org/jira/browse/DRILL-4411
> Project: Apache Drill
> Issue Type: Bug
> Components: Server
> Reporter: MinJi Kim
> Assignee: MinJi Kim
> Priority: Major
>
> In HashJoinProbeTemplate, each batch is limited to TARGET_RECORDS_PER_BATCH
> (4000). But we should not only depend on the number of records, but also
> size (in case of extremely large records).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
