[ 
https://issues.apache.org/jira/browse/DRILL-6343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16498396#comment-16498396
 ] 

Parth Chandra commented on DRILL-6343:
--------------------------------------

That's correct. The BitVector used for the nullable bit was changed to a 
Uint1Vector for performance. 

BitVector seems to be used in the Parquet reader, the Parquet writer, and the 
Kudu reader. The Parquet reader changes are trivial, but I'm not so sure of the 
other places where it is used. 

Going to merge this change as part of PR 1227

> bit vector copyFromSafe is not doing realloc 
> ---------------------------------------------
>
>                 Key: DRILL-6343
>                 URL: https://issues.apache.org/jira/browse/DRILL-6343
>             Project: Apache Drill
>          Issue Type: Bug
>          Components: Execution - Flow
>    Affects Versions: 1.13.0
>            Reporter: Padma Penumarthy
>            Assignee: Padma Penumarthy
>            Priority: Major
>             Fix For: 1.14.0
>
>
> bit vector copyFromSafe simply returns false when asked to copy to an index 
> greater than it's capacity. It should do realloc if needed and copy correctly.
> This bug is very subtle and shows up as random wrong result. allocateNew for 
> bit vector allocates 4096 bytes initially and if we do copyFromSafe to any 
> index greater than that, we basically do not do any copy, but just return 
> false. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to