[
https://issues.apache.org/jira/browse/DRILL-5796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16500265#comment-16500265
]
ASF GitHub Bot commented on DRILL-5796:
---------------------------------------
arina-ielchiieva commented on a change in pull request #1298: DRILL-5796:
Filter pruning for multi rowgroup parquet file
URL: https://github.com/apache/drill/pull/1298#discussion_r192746227
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/stat/ParquetBooleanPredicates.java
##########
@@ -44,15 +44,31 @@ public AndPredicate(String name, List<LogicalExpression>
args, ExpressionPositio
super(name, args, pos);
}
+ /**
+ * Evaluates a compound "AND" filter on the statistics of a RowGroup (the
filter reads "filterA and filterB").
+ * Return value :<ul>
+ * <li>ALL : only if all filters return ALL
+ * <li>NONE : if one filter at least returns NONE
+ * <li>MISLEAD : all other cases
+ * </ul>
+ */
@Override
- public boolean canDrop(RangeExprEvaluator evaluator) {
- // "and" : as long as one branch is OK to drop, we can drop it.
+ public ROWS_MATCH matches(RangeExprEvaluator evaluator) {
+ ROWS_MATCH m, temp = ROWS_MATCH.NONE;
for (LogicalExpression child : this) {
- if (child instanceof ParquetFilterPredicate &&
((ParquetFilterPredicate) child).canDrop(evaluator)) {
- return true;
+ m = ((ParquetFilterPredicate) child).matches(evaluator);
Review comment:
1. It would be better if variables `m`, `temp` would have meaning names,
please consider the same in other places.
2. I believe it's better to leaving `instanceof` check.
3. Please consider re-writing below if statements to be more simple.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Filter pruning for multi rowgroup parquet file
> ----------------------------------------------
>
> Key: DRILL-5796
> URL: https://issues.apache.org/jira/browse/DRILL-5796
> Project: Apache Drill
> Issue Type: Improvement
> Components: Storage - Parquet
> Reporter: Damien Profeta
> Assignee: Jean-Blas IMBERT
> Priority: Major
> Fix For: 1.14.0
>
>
> Today, filter pruning use the file name as the partitioning key. This means
> you can remove a partition only if the whole file is for the same partition.
> With parquet, you can prune the filter if the rowgroup make a partition of
> your dataset as the unit of work if the rowgroup not the file.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
