[
https://issues.apache.org/jira/browse/DRILL-5584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16500979#comment-16500979
]
ASF GitHub Bot commented on DRILL-5584:
---------------------------------------
parthchandra commented on issue #1039: DRILL-5584: Add branding and versioning
information for windows C++ C…
URL: https://github.com/apache/drill/pull/1039#issuecomment-394524107
Committed as 9908ea0
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> When Compiling Apache Drill C++ Client, versioning information are not
> present in the binary
> --------------------------------------------------------------------------------------------
>
> Key: DRILL-5584
> URL: https://issues.apache.org/jira/browse/DRILL-5584
> Project: Apache Drill
> Issue Type: Improvement
> Components: Client - C++
> Affects Versions: 1.10.0
> Reporter: Rob Wu
> Priority: Minor
>
> We should add support for generating an RC file containing the versioning
> information so this manual task can be automated.
> Current workaround:
> Compile the C++ Client DLL.
> Open the DLL and manually add a Version Resource with the following
> information:
> FILEVERSION 1,10,0,0
> PRODUCTVERSION 1,10,0,0
> CompanyName
> FileDescription Apache Drill C++ Client
> FileVersion 1.10.0.0
> InternalName drillClient.dll
> LegalCopyright Copyright (c) 2013-2017 The Apache Software
> Foundation
> OriginalFilename drillClient.dll
> ProductName Apache Drill C++ Client
> ProductVersion 1.10.0.0
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
