[
https://issues.apache.org/jira/browse/DRILL-6463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16501097#comment-16501097
]
ASF GitHub Bot commented on DRILL-6463:
---------------------------------------
vrozov commented on a change in pull request #1303: DRILL-6463 : Fix integer
overflow in MockGroupScanPOP
URL: https://github.com/apache/drill/pull/1303#discussion_r192920347
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/ConvertCountToDirectScan.java
##########
@@ -121,9 +121,9 @@ public void onMatch(RelOptRuleCall call) {
final RelDataType scanRowType = constructDataType(agg, result.keySet());
- final DynamicPojoRecordReader<Long> reader = new DynamicPojoRecordReader<>(
+ final DynamicPojoRecordReader<Double> reader = new
DynamicPojoRecordReader<>(
Review comment:
This will change return type for "select count(*) ...", let's keep it to
`Long`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> ProfileParser cannot parse costs when using MockScanBatch
> ---------------------------------------------------------
>
> Key: DRILL-6463
> URL: https://issues.apache.org/jira/browse/DRILL-6463
> Project: Apache Drill
> Issue Type: Bug
> Affects Versions: 1.13.0
> Reporter: Gautam Kumar Parai
> Assignee: Gautam Kumar Parai
> Priority: Major
> Fix For: 1.14.0
>
>
> One of the unit testHashAggrSecondaryTertiarySpill() runs into this issue
> although the issue is generic. It happens due to cost being stored in an int
> which overflows with big enough rows/data size and becomes negative. This
> causes the Profile parser to error out on seeing negative costs.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
