[
https://issues.apache.org/jira/browse/DRILL-5796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16501621#comment-16501621
]
ASF GitHub Bot commented on DRILL-5796:
---------------------------------------
arina-ielchiieva commented on issue #1298: DRILL-5796: Filter pruning for multi
rowgroup parquet file
URL: https://github.com/apache/drill/pull/1298#issuecomment-394677367
@jbimbert overall looks good, except of several minor comments. Please
address them and squash the commits into one.
Also I have run Functional and Advanced tests for your branch and there is
one test failure:
```
Query:
/root/drillAutomation/drill-test-framework/framework/resources/Functional/filter/pushdown/data/DRILL_6259_filter_push_down_top_level_array.sql
select * from
dfs.drillTestDir.`parquet_storage/DRILL_6259/DRILL_6259_test_data` t where
t.top_level_array[2] >= 20
Baseline:
/root/drillAutomation/drill-test-framework/framework/resources/Functional/filter/pushdown/data/DRILL_6259_filter_push_down_top_level_array.e_tsv
Expected number of rows: 1
Actual number of rows from Drill: 2
Number of matching rows: 1
Number of rows missing: 0
Number of rows unexpected: 1
These rows are not expected (first 10):
d3 3 1487165823000 [31,32]
{"nested_array":[false,true,false,false],"nested_complex_field":{"nested_array":[true,false,false,true]},"nested_list_of_complex_fields":[{"nested_array":[1131,1132,1133,1134]},{"nested_field":1485400063000,"nested_array":[1134,1135,1136,1137]},{"nested_field":1485488351000,"nested_array":[1137,1138,1139,1140]}]}
[{"nested_array":[131,132,133,134],"nested_complex_field":{"nested_array":[1485576639000,1485663099000]},"nested_list_of_complex_fields":[{"nested_array":[1131,1133]},{"nested_field":true,"nested_array":[1134,1135,1136,1137]},{"nested_field":false,"nested_array":[1137,1138,1139]}]},{"nested_field":true,"nested_array":[321,322,323],"nested_complex_field":{"nested_field":321,"nested_array":[1488255039000,1488255099000,1488341499000]},"nested_list_of_complex_fields":[{"nested_field":false,"nested_array":[1321,1322,1323]},{"nested_field":true,"nested_array":[1324,1325,1326]},{"nested_field":false,"nested_array":[1327,1328,1329]}]},{"nested_field":true,"nested_array":[331,332,333],"nested_complex_field":{"nested_field":331,"nested_array":[1489774239000,1489774299000,1489860699000]},"nested_list_of_complex_fields":[{"nested_field":false,"nested_array":[1331,1332,1333]},{"nested_field":true,"nested_array":[1334,1335,1336]},{"nested_field":true,"nested_array":[1337,1338,1339]}]}]
```
Data -
https://github.com/mapr/drill-test-framework/tree/master/framework/resources/Datasources/parquet_storage/DRILL_6259/DRILL_6259_test_data
Query -
https://github.com/mapr/drill-test-framework/blob/master/framework/resources/Functional/filter/pushdown/data/DRILL_6259_filter_push_down_top_level_array.sql
Expected result -
https://github.com/mapr/drill-test-framework/blob/master/framework/resources/Functional/filter/pushdown/data/DRILL_6259_filter_push_down_top_level_array.e_tsv
Please fix it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Filter pruning for multi rowgroup parquet file
> ----------------------------------------------
>
> Key: DRILL-5796
> URL: https://issues.apache.org/jira/browse/DRILL-5796
> Project: Apache Drill
> Issue Type: Improvement
> Components: Storage - Parquet
> Reporter: Damien Profeta
> Assignee: Jean-Blas IMBERT
> Priority: Major
> Fix For: 1.14.0
>
>
> Today, filter pruning use the file name as the partitioning key. This means
> you can remove a partition only if the whole file is for the same partition.
> With parquet, you can prune the filter if the rowgroup make a partition of
> your dataset as the unit of work if the rowgroup not the file.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
