[ 
https://issues.apache.org/jira/browse/DRILL-6473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16503464#comment-16503464
 ] 

ASF GitHub Bot commented on DRILL-6473:
---------------------------------------

KazydubB commented on a change in pull request #1307: DRILL-6473: Upgrade Drill 
1.14 with Hive 2.3 for mapr profile
URL: https://github.com/apache/drill/pull/1307#discussion_r193456947
 
 

 ##########
 File path: 
contrib/storage-hive/core/src/main/java/org/apache/drill/exec/store/hive/readers/HiveAbstractReader.java
 ##########
 @@ -203,20 +204,8 @@ private void init() throws ExecutionSetupException {
           }
         }
       }
-      ColumnProjectionUtils.appendReadColumns(job, columnIds);
-
-      // TODO: Use below overloaded method instead of above simpler version of 
it, once Hive client dependencies
-      // (from all profiles) will be updated to 2.3 version or above
-//      ColumnProjectionUtils.appendReadColumns(job, columnIds, 
selectedColumnNames,
-//          Lists.newArrayList(Iterables.transform(getColumns(), new 
Function<SchemaPath, String>()
-//      {
-//        @Nullable
-//        @Override
-//        public String apply(@Nullable SchemaPath path)
-//        {
-//          return path.getRootSegmentPath();
-//        }
-//      })));
+      ColumnProjectionUtils.appendReadColumns(job, columnIds, 
selectedColumnNames,
+          Lists.newArrayList(Iterables.transform(getColumns(), 
SchemaPath::getRootSegmentPath)));
 
 Review comment:
   Done.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


> Upgrade Drill 1.14 with Hive 2.3 for mapr profile
> -------------------------------------------------
>
>                 Key: DRILL-6473
>                 URL: https://issues.apache.org/jira/browse/DRILL-6473
>             Project: Apache Drill
>          Issue Type: Task
>            Reporter: Bohdan Kazydub
>            Assignee: Bohdan Kazydub
>            Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to