[
https://issues.apache.org/jira/browse/DRILL-5796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16513973#comment-16513973
]
ASF GitHub Bot commented on DRILL-5796:
---------------------------------------
vrozov commented on a change in pull request #1298: DRILL-5796: Filter pruning
for multi rowgroup parquet file
URL: https://github.com/apache/drill/pull/1298#discussion_r195777836
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/stat/ParquetFilterPredicate.java
##########
@@ -18,5 +18,17 @@
package org.apache.drill.exec.expr.stat;
public interface ParquetFilterPredicate<T extends Comparable<T>> {
- boolean canDrop(RangeExprEvaluator<T> evaluator);
+
+ /**
+ * Define the validity of a row group against a filter
+ * <ul>
+ * <li>ALL : all rows match the filter (can not drop the row group and
prune filter)
+ * <li>NONE : no row matches the filter (can drop the row group)
+ * <li>SOME : some rows only match the filter (can not drop the row group
not the filter)
+ * <li>INAPPLICABLE : filter can not be applied
+ * </ul>
+ */
+ enum ROWS_MATCH {ALL, NONE, SOME, INAPPLICABLE}
Review comment:
It is more common for Drill to use all capital formatting only for enum
values, the enum itself uses Camel notation.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Filter pruning for multi rowgroup parquet file
> ----------------------------------------------
>
> Key: DRILL-5796
> URL: https://issues.apache.org/jira/browse/DRILL-5796
> Project: Apache Drill
> Issue Type: Improvement
> Components: Storage - Parquet
> Reporter: Damien Profeta
> Assignee: Jean-Blas IMBERT
> Priority: Major
> Fix For: 1.14.0
>
>
> Today, filter pruning use the file name as the partitioning key. This means
> you can remove a partition only if the whole file is for the same partition.
> With parquet, you can prune the filter if the rowgroup make a partition of
> your dataset as the unit of work if the rowgroup not the file.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
