[ 
https://issues.apache.org/jira/browse/DRILL-6513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16517500#comment-16517500
 ] 

ASF GitHub Bot commented on DRILL-6513:
---------------------------------------

sachouche opened a new pull request #1329: DRILL-6513: Max query memory per 
node set to Drillbit's max direrct memory
URL: https://github.com/apache/drill/pull/1329
 
 
   Changed the "planner.memory.max_query_memory_per_node" configuration 
parameter maximum value to be the Drillbit maximum direct memory. 
   
   **NOTE -** This change (as described in the JIRA) will not address all 
issues related to this configuration value as this is out-of-scope and 
currently not possible; future enhancements shall happen along with the Drill 
Resource Management feature. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


> Drill should only allow valid values when users set 
> planner.memory.max_query_memory_per_node
> --------------------------------------------------------------------------------------------
>
>                 Key: DRILL-6513
>                 URL: https://issues.apache.org/jira/browse/DRILL-6513
>             Project: Apache Drill
>          Issue Type: Bug
>          Components: Query Planning & Optimization
>            Reporter: salim achouche
>            Assignee: salim achouche
>            Priority: Major
>             Fix For: 1.14.0
>
>
> The "planner.memory.max_query_memory_per_node" configuration can be currently 
> set to values higher than the Drillbit Direct Memory configuration. The goal 
> of this Jira is to fail queries with such an erroneous configuration to avoid 
> runtime OOM.
> NOTE - The current semantic of the maximum query memory per node 
> configuration is that the end user has computed valid values especially 
> knowing the current Drill limitations. Such values have to account for 
> Netty's overhead (memory pools), shared pools (e.g., network exchanges), and 
> concurrent query execution. This Jira should not be used to also cover such 
> use-cases. The Drill Resource Management feature has the means to automate 
> query quotas and the associated validation. We should create another Jira 
> requesting the enhanced validations contracts under the umbrella of the 
> Resource Management feature.   
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to