[ 
https://issues.apache.org/jira/browse/DRILL-6454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16517979#comment-16517979
 ] 

ASF GitHub Bot commented on DRILL-6454:
---------------------------------------

vdiravka commented on a change in pull request #1314: DRILL-6454: Native MapR 
DB plugin support for Hive MapR-DB json table
URL: https://github.com/apache/drill/pull/1314#discussion_r196598080
 
 

 ##########
 File path: 
exec/java-exec/src/main/java/org/apache/drill/exec/ExecConstants.java
 ##########
 @@ -387,9 +387,12 @@ private ExecConstants() {
 
   // TODO: We need to add a feature that enables storage plugins to add their 
own options. Currently we have to declare
   // in core which is not right. Move this option and above two mongo plugin 
related options once we have the feature.
-  public static final String HIVE_OPTIMIZE_SCAN_WITH_NATIVE_READERS = 
"store.hive.optimize_scan_with_native_readers";
-  public static final OptionValidator 
HIVE_OPTIMIZE_SCAN_WITH_NATIVE_READERS_VALIDATOR =
-      new BooleanValidator(HIVE_OPTIMIZE_SCAN_WITH_NATIVE_READERS);
+  public static final String HIVE_OPTIMIZE_PARQUET_SCAN_WITH_NATIVE_READER = 
"store.hive.parquet.optimize_scan_with_native_readers";
 
 Review comment:
   The old name is not right in order of using several native readers for Hive 
plugin. 
   But I will keep the old property name as Deprecated for backward 
compatibility and will leave a comment that it should be removed starting from 
next 1.15.0 release.
   
   The new property name is also introduced, so both of them can enable 
`parquet native reader`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


> Native MapR DB plugin support for Hive MapR-DB json table
> ---------------------------------------------------------
>
>                 Key: DRILL-6454
>                 URL: https://issues.apache.org/jira/browse/DRILL-6454
>             Project: Apache Drill
>          Issue Type: New Feature
>          Components: Storage - Hive, Storage - MapRDB
>    Affects Versions: 1.13.0
>            Reporter: Vitalii Diravka
>            Assignee: Vitalii Diravka
>            Priority: Major
>              Labels: doc-impacting
>             Fix For: 1.14.0
>
>
> Hive can create and query MapR-DB tables via maprdb-json-handler:
> https://maprdocs.mapr.com/home/Hive/ConnectingToMapR-DB.html
> The aim of this Jira to implement Drill native reader for Hive MapR-DB tables 
> (similar to parquet).
> Design proposal is:
> - to use JsonTableGroupScan instead of HiveScan;
> - to add storage planning rule to convert HiveScan to MapRDBGroupScan;
> - to add system/session option to enable using of this native reader;
> - native reader can be used only for Drill build with mapr profile (there is 
> no reason to leverage it for default profile);
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to