[
https://issues.apache.org/jira/browse/DRILL-6310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16518640#comment-16518640
]
ASF GitHub Bot commented on DRILL-6310:
---------------------------------------
Ben-Zvi commented on a change in pull request #1324: DRILL-6310: limit batch
size for hash aggregate
URL: https://github.com/apache/drill/pull/1324#discussion_r196953241
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/common/HashTableTemplate.java
##########
@@ -111,6 +111,31 @@
private int resizingTime = 0;
+
+ // Given hashtable index, figure out the corresponding index in the batch.
+ public int idxInBatch(int idx) {
Review comment:
The original code referred to location as a pair: < batch-num ;
index-in-batch >
This was condensed into a 4 byte "int", each element in a 2 byte.
With this model, any batch can be of a different size, and access be done as
before (e.g. **& BATCH_MASK**). Only "did we reach the limit" checks need to be
done against the per-batch limit.
The code that accesses the hash table is super hot code (per each row
inserted, searched, etc). Thus running thru such loops is a big performance
penalty !!!!!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> limit batch size for hash aggregate
> -----------------------------------
>
> Key: DRILL-6310
> URL: https://issues.apache.org/jira/browse/DRILL-6310
> Project: Apache Drill
> Issue Type: Improvement
> Components: Execution - Flow
> Affects Versions: 1.13.0
> Reporter: Padma Penumarthy
> Assignee: Padma Penumarthy
> Priority: Major
> Fix For: 1.14.0
>
>
> limit batch size for hash aggregate based on memory.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
