[
https://issues.apache.org/jira/browse/DRILL-6340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16518835#comment-16518835
]
ASF GitHub Bot commented on DRILL-6340:
---------------------------------------
ilooner commented on a change in pull request #1302: DRILL-6340: Output Batch
Control in Project using the RecordBatchSizer
URL: https://github.com/apache/drill/pull/1302#discussion_r196996181
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/project/ProjectRecordBatch.java
##########
@@ -193,6 +209,13 @@ protected IterOutcome doWork() {
}
}
incomingRecordCount = incoming.getRecordCount();
+ memoryManager.update();
+ if (logger.isTraceEnabled()) {
+ logger.trace("doWork():[1] memMgr RC " +
memoryManager.getOutputRowCount()
Review comment:
It's easier to read for the programmer. Also the string concatenation is
only executed if the debug statement is executed. If you use + you have to have
if statements around your debug statements to avoid any performance impact.
```
if (logger.isDebug()) {
logger.debug("my " + variable + " message");
}
```
If you use the {} you don't have to have if statements in order to prevent a
performance impact since the concatenation is delayed and only executed if the
log level allows debugging.
```
logger.debug("my {} message", variable);
```
It's typically considered best practice to do the latter since it's much
cleaner.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Output Batch Control in Project using the RecordBatchSizer
> ----------------------------------------------------------
>
> Key: DRILL-6340
> URL: https://issues.apache.org/jira/browse/DRILL-6340
> Project: Apache Drill
> Issue Type: Improvement
> Components: Execution - Relational Operators
> Reporter: Karthikeyan Manivannan
> Assignee: Karthikeyan Manivannan
> Priority: Major
> Labels: doc-impacting
> Fix For: 1.14.0
>
>
> This bug is for tracking the changes required to implement Output Batch
> Sizing in Project using the RecordBatchSizer. The challenge in doing this
> mainly lies in dealing with expressions that produce variable-length columns.
> The following doc talks about some of the design approaches for dealing with
> such variable-length columns.
> [https://docs.google.com/document/d/1h0WsQsen6xqqAyyYSrtiAniQpVZGmQNQqC1I2DJaxAA/edit?usp=sharing]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
