[
https://issues.apache.org/jira/browse/DRILL-6545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16526944#comment-16526944
]
ASF GitHub Bot commented on DRILL-6545:
---------------------------------------
amansinha100 commented on a change in pull request #1347: DRILL-6545:
Projection Push down into Lateral Join operator.
URL: https://github.com/apache/drill/pull/1347#discussion_r199018067
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillProjectLateralJoinTransposeRule.java
##########
@@ -0,0 +1,46 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.drill.exec.planner.logical;
+
+
+import org.apache.calcite.plan.RelOptRuleCall;
+import org.apache.calcite.rel.core.Correlate;
+import org.apache.calcite.rel.core.RelFactories;
+import org.apache.calcite.rel.rules.ProjectCorrelateTransposeRule;
+import org.apache.calcite.rel.rules.PushProjector;
+import org.apache.calcite.tools.RelBuilderFactory;
+
+public class DrillProjectLateralJoinTransposeRule extends
ProjectCorrelateTransposeRule {
+
+ public static final DrillProjectLateralJoinTransposeRule INSTANCE = new
DrillProjectLateralJoinTransposeRule(PushProjector.ExprCondition.TRUE,
RelFactories.LOGICAL_BUILDER);
+
+ public DrillProjectLateralJoinTransposeRule(PushProjector.ExprCondition
preserveExprCondition, RelBuilderFactory relFactory) {
+ super(preserveExprCondition, relFactory);
+ }
+
+ @Override
+ public boolean matches(RelOptRuleCall call) {
+ Correlate correlate = call.rel(1);
+
+ if (correlate instanceof DrillLateralJoinRel &&
((DrillLateralJoinRel)correlate).excludeCorrelateColumn) {
Review comment:
Pls add a comment why this should not match if excludeCorrelateColumn is
true.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Projection Push down into Lateral Join operator.
> ------------------------------------------------
>
> Key: DRILL-6545
> URL: https://issues.apache.org/jira/browse/DRILL-6545
> Project: Apache Drill
> Issue Type: Improvement
> Components: Query Planning & Optimization
> Reporter: Hanumath Rao Maduri
> Assignee: Hanumath Rao Maduri
> Priority: Major
> Fix For: 1.14.0
>
>
> For the Lateral’s logical and physical plan node, we would need to add an
> output RowType such that a Projection can be pushed down to Lateral.
> Currently, Lateral will produce all columns from left and right and it
> depends on a subsequent Project to eliminate unneeded columns. However, this
> will blow up the memory use of Lateral since each column from the left will
> be replicated N times based on N rows coming from UNNEST. We can have a
> ProjectLateralPushdownRule that pushes only the plain columns onto LATERAL
> but keeps the expression evalulations as part of the Project above the
> Lateral.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
