[
https://issues.apache.org/jira/browse/DRILL-6494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16528427#comment-16528427
]
ASF GitHub Bot commented on DRILL-6494:
---------------------------------------
vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins
Handler
URL: https://github.com/apache/drill/pull/1345#discussion_r198884749
##########
File path: common/src/main/java/org/apache/drill/exec/metrics/DrillMetrics.java
##########
@@ -36,11 +36,11 @@
private static final org.slf4j.Logger logger =
org.slf4j.LoggerFactory.getLogger(DrillMetrics.class);
public static final boolean METRICS_JMX_OUTPUT_ENABLED =
- SystemPropertyUtil.getBoolean("drill.metrics.jmx.enabled", true);
+ SystemPropertyUtil.getBoolean("drill.exec.metrics.jmx.enabled", true);
Review comment:
The issues comes from `drill-override-example.conf`:
https://github.com/apache/drill/blob/master/distribution/src/resources/drill-override-example.conf#L22
https://github.com/apache/drill/blob/master/distribution/src/resources/drill-override-example.conf#L66
Since drill.apache.org tells the options without `exec`
[link](https://drill.apache.org/docs/monitoring-metrics/#disabling-drill-metrics)
I reverted the constants names and changed `drill-override-example.conf`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Drill Plugins Handler
> ---------------------
>
> Key: DRILL-6494
> URL: https://issues.apache.org/jira/browse/DRILL-6494
> Project: Apache Drill
> Issue Type: New Feature
> Components: Tools, Build & Test
> Affects Versions: 1.13.0
> Reporter: Vitalii Diravka
> Assignee: Vitalii Diravka
> Priority: Major
> Labels: doc-impacting
> Fix For: 1.14.0
>
> Attachments: storage-plugins.conf
>
>
> The new service of updating Drill's plugins configs could be implemented.
> Please find details from design overview document:
> https://docs.google.com/document/d/14JKb2TA8dGnOIE5YT2RImkJ7R0IAYSGjJg8xItL5yMI/edit?usp=sharing
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
